make use of `nw.Window.open` to open default window

Open ghostoy opened this issue 9 years ago • 2 comments

The original logic in default.js is duplicated to the implementation in nw.Window.open, which could easily bring inconsistancy or bugs. e.g. in nwjs/nw.js#5247, x and y parameters are missed in the script. Just make use of nw.Window.open to open the default window can fix these issues.

Sep 01 '16 08:09 ghostoy

@rogerwang This PR will also fix regression in nwjs/nw.js#5387. And it will prevent such regressions caused by inconsistent options between nw.Window.open and window fields in package.json. Please consider to merge it.

Oct 26 '16 07:10 ghostoy

@rogerwang Please review and merge this patch in order to prevent future regressions.

Nov 08 '16 07:11 ghostoy