chromium.src icon indicating copy to clipboard operation
chromium.src copied to clipboard
verified publisher icon nwjs

[win] fix menubar background

Open ghostoy opened this issue 9 years ago • 6 comments

Menubar background should be consistent with the theme by the system. On Windows, we use COLOR_MENU for the background color for menubar.

fixed nwjs/nw.js#4851

ghostoy avatar Jun 29 '16 12:06 ghostoy

@rogerwang Please review and merge this backport of #28.

ghostoy avatar Jul 14 '16 02:07 ghostoy

This will be merged after other changes in stable branch are back-ported.

rogerwang avatar Jul 15 '16 01:07 rogerwang

@ghostoy According to release notes this problem is fixed in NW.js v0.16.0-rc1. Please provide an example how to set the color of the menu bar. Thank you.

Pumpernickel61 avatar Aug 01 '16 19:08 Pumpernickel61

@Pumpernickel61 You can't set color of menubar. But it will be rendered same color as your OS theme, same as Electron.

ghostoy avatar Aug 02 '16 00:08 ghostoy

@ghostoy Ah, I see, sorry for my misunderstanding. And I just tried it, in nw 0.15 the menubar background was white and now in nw 0.16 it is light grey, same like in Atom editor (Electron based) :-)

Pumpernickel61 avatar Aug 02 '16 06:08 Pumpernickel61

@rogerwang Is it ready for merge to nw14?

ghostoy avatar Nov 08 '16 07:11 ghostoy