Nikolas Schröter

Results 56 comments of Nikolas Schröter

@hugop95 Thanks for getting back so quickly! Got it. I agree with the naming change now that you explained it, so I suppose this would also only be applicable when...

@hugop95 Couldn't we use `string[]` groups for this? The `internal` and `external` groups are likely to be sorted together anyways. Subsequently I would also expect a `commentBetween` to always apply...

@hugop95 Ah, I see now. First thought that comes to mind is unsetting it, but I will chew on better alternatives. ```jsonc { // ... "groups": [ "utils", { "commentBetween":...

@hugop95 I guess it can never be fully safe, but we could use hidden characters in the comments to mark them as garbage-collectible.

@hugop95 Any updates on this? I would also be glad to help out if useful.

@hugop95 Thanks for the update , I took some time to take a look at this and have both questions as well as feedback. Generally, it looks to be heading...

@hugop95 Yep, 2.) Is likely caused by [`multiline-comment-style`](https://eslint.org/docs/latest/rules/multiline-comment-style) running in the exact sequence you described. I will see whether I can put the build through another round of testing today...

@hugop95 Looking good now 👍 I was wondering what the reason was for pushing existing comments downwards instead of upwards? This could be problematic for people having a license banner...

> I think that the easiest fix is to use the current logic with an added condition: always put the auto-added comment above the "highest" node comment, but exclude the...

@hugop95 The other issue was coming from `'import/newline-after-import': [ 'error' ]` 👍