Nathan Sarang-Walters

Results 624 comments of Nathan Sarang-Walters

I just opened https://github.com/PrairieLearn/PrairieLearn/pull/11995 as a response to recent feedback on Slack, as this was straightforward to implement. I think adding some kind of validation for course instance access dates...

This is a reasonable-enough change to land as is. I have a WIP navigation rework in the `lti-integration-navigation` branch that we can revisit if we want more comprehensive changes in...

Note to self: I'd like to test this end-to-end once more before merging, specifically what happens when one lands on this page without being authed.

I tested this locally in the above scenario. That is, before emulating a student in Canvas and opening the assessment linked to PL, I first logged out of PL entirely....

AFAICT the above is caused by Chrome's default blocking of third-party cookies, which happens when we try to establish a session (which sends a new `Set-Cookie` header) inside an iframe.

Canvas has written about this problem already: https://community.canvaslms.com/t5/The-Product-Blog/Canvas-Stays-Solid-as-Third-Party-Cookies-Crumble/ba-p/605051 This gives us a few options to try: - Try adding `Partitioned` to our cookies. This will mean that auth in a...

We discussed the `points`/`autoPoints` question in yesterday's dev meeting. Two takeaways: - We've decided we're happy to canonicalize people's JSON files. Just like we apply Prettier for canonical formatting, we'll...

I'm still experiencing this on Vite 5.4.10, which should include the changes linked above (per https://github.com/vitejs/vite/blob/v5.4.11/packages/vite/CHANGELOG.md, they were released in 5.4.9). This is reproducible here: https://github.com/getsentry/sentry-javascript/pull/14968. Should I report this...

👋 thanks for opening this! Please ensure you resolve the merge conflicts so that CI can proceed.

I took the liberty of resolving the merge conflicts. There are some CI issues that will need to be addressed.