Nathan Sarang-Walters

Results 624 comments of Nathan Sarang-Walters

This is still applicable. It's waiting for review by a maintainer.

https://github.com/aws/aws-sdk-js/blob/c44ef6f16d51965a1e4dd10981d0cbcd7c5f9078/lib/maintenance_mode_message.js#L11-L15 Per this, the following should work: ```js require('aws-sdk/lib/maintenance_mode_message').suppress = true; ``` This should be documented somewhere more visible than the source code.

I'm in agreement with you. You specifically asked for a way to suppress the warning message; one already exists.

Another reason to remove this warning entirely: the v3 SDK isn't even feature-complete (see https://github.com/aws/aws-sdk-js-v3/issues/4004), so I literally *can't* move to it, no matter how much I want to.

I've noticed that `aws-sdk/lib/maintenance_mode_message` is also not reflected in the TypeScript types, which means we have to jump through more hoops in our TypeScript project to disable this warning.

I raised the `cpu-features` issue before here: https://github.com/oven-sh/bun/issues/158#issuecomment-1758677166 This is frustrating because `ssh2`, the package that actually uses `cpu-features` here, is _designed_ to gracefully handle the case where it can't...

Unfortunately I don't have access to a Windows machine to test it on. I imagine the behavior could vary between different tools on Windows.

@chimurai is there any chance you'd be able to review soon? If so, I'll resolve the merge conflicts with master.

@dogabudak any chance you could take a look at this?

This will require https://github.com/janl/mustache.js/issues/599, which unfortunately seems unlikely to resolve. There are some other potential solutions mentioned on that issue, including some that recursively wrap data in proxy objects or...