github-dependents-info icon indicating copy to clipboard operation
github-dependents-info copied to clipboard

correct total dependents count

Open jzhang533 opened this issue 2 months ago • 0 comments

Description

Change to extract total_dependents

seems extracting total_dependents from the html page is incorrect, probably because GH has updated the page. this PR solve the issue.

before

github-dependents-info --repo nvuillam/github-dependents-info will output:

WARNING:root:WARNING: Unable to get integer from ""
WARNING:root:WARNING: Unable to get integer from ""
Total: 11
Public: 11 (145 stars)
Private: -11

after

github-dependents-info --repo nvuillam/github-dependents-info will output:

Total: 12
Public: 11 (145 stars)
Private: 1

a timedelay option

a timedelay option has been added, this controls how long to wait (use time.sleep) between two requests to github, this is useful for repository with a very long dependents list.

Related Issue

not found

Type of Change

  • [ ] 📚 Examples / docs / tutorials / dependencies update
  • [x] 🔧 Bug fix (non-breaking change which fixes an issue)
  • [ ] 🥂 Improvement (non-breaking change which improves an existing feature)
  • [ ] 🚀 New feature (non-breaking change which adds functionality)
  • [ ] 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] 🔐 Security fix

Checklist

  • [x] I've read the CODE_OF_CONDUCT.md document.
  • [ ] I've read the CONTRIBUTING.md guide.
  • [ ] I've updated the code style using make codestyle.
  • [ ] I've written tests for all new methods and classes that I created.
  • [ ] I've written the docstring in Google format for all the methods and classes that I used.

jzhang533 avatar Apr 22 '24 08:04 jzhang533