nvm icon indicating copy to clipboard operation
nvm copied to clipboard

Skip checksum when download file failed.

Open Buguin opened this issue 2 years ago • 5 comments

Fixes #3075 Check if the file is successfully downloaded

Buguin avatar Apr 06 '23 14:04 Buguin

Ÿ

freddyg11 avatar Apr 12 '23 08:04 freddyg11

@Buguin are you still interested in completing this PR?

ljharb avatar May 17 '23 21:05 ljharb

@Buguin are you still interested in completing this PR?

Sorry,I'm too busy working this time. Recently, I will make a push to solve the problem of not being able to return when an error is reported in the following code.

nvm_err "Downloading ${TARBALL_URL}..."
  nvm_download -L -C - "${PROGRESS_BAR}" "${TARBALL_URL}" -o "${TARBALL}" || (
    command rm -rf "${TARBALL}" "${tmpdir}"
    nvm_err "Binary download from ${TARBALL_URL} failed, trying source."
    return 4---it does not work, function not return.
  )

Buguin avatar May 23 '23 12:05 Buguin

@Buguin are you still interested in completing this PR?

I have transformed nvm_download_artifact function, which allows you to determine the download status based on the execution results.

Buguin avatar May 29 '23 14:05 Buguin

I've rebased this, but it still needs tests. @Buguin any chance you're still interesting in completing this PR?

ljharb avatar Jul 29 '24 00:07 ljharb