nvm icon indicating copy to clipboard operation
nvm copied to clipboard

Published 20 hours ago • verified publisher icon nvm-sh

update test data for node 18 lts release

Open ryenus opened this issue 3 years ago • 4 comments

lts/gallium is node 16, while lts/hydrogen is node 18.

This fixes the following test:

  • nvm_list_aliases works with LTS aliases

ryenus avatar Nov 02 '22 14:11 ryenus

Just to get the CI working first, I don't think it's a good test though.

ryenus avatar Nov 02 '22 15:11 ryenus

This will fail, because Travis is on xenial which can’t build node 18. If you can help install the right C libs on Xenial, that would unblock this :-)

ljharb avatar Nov 02 '22 15:11 ljharb

This will fail, because Travis is on xenial which can’t build node 18. If you can help install the right C libs on Xenial, that would unblock this :-)

Hmmm, that's way more than I had expected, not sure if I could figure that out but I think that will require a separate PR or something?

ryenus avatar Nov 03 '22 06:11 ryenus

I think this PR should end up containing that fix. It's definitely a much larger change.

ljharb avatar Nov 03 '22 06:11 ljharb

I've updated this with a commit that runs the "update test mocks" script (and fixed tests on master)

ljharb avatar Dec 23 '22 19:12 ljharb