nvm icon indicating copy to clipboard operation
nvm copied to clipboard

Published 20 hours ago • verified publisher icon nvm-sh

Feat: Remove the version in the nvm use instruction

Open deepakchethan opened this issue 2 years ago • 6 comments

Fixes #2701

deepakchethan avatar Mar 17 '22 13:03 deepakchethan

Will open reopen the pr once I fix the tests

deepakchethan avatar Mar 17 '22 14:03 deepakchethan

The change is very much not to unconditionally remove the version - the only time it doesn’t belong there is when an nvmrc is present and a version is inferred from that.

ljharb avatar Mar 17 '22 15:03 ljharb

Got it @ljharb, Will create a pr with a proper fix.

deepakchethan avatar Mar 17 '22 15:03 deepakchethan

Can you restore this branch and reopen this PR so i can keep both this and #2770 in sync?

ljharb avatar Mar 22 '22 17:03 ljharb

Hello @ljharb, I have restored and reopened this PR. Please let me know if you want me to rebase this as well

deepakchethan avatar Mar 23 '22 01:03 deepakchethan

Thanks, i can take care of it for you.

ljharb avatar Mar 23 '22 02:03 ljharb