nvm icon indicating copy to clipboard operation
nvm copied to clipboard

Add check to nvm profile for nvm path

Open sladyn98 opened this issue 4 years ago • 5 comments

This PR aims to add a check for the profile before adding the path Closes https://github.com/nvm-sh/nvm/issues/2076

sladyn98 avatar Mar 18 '21 12:03 sladyn98

 ✓ nvm_check_global_modules
  ✓ nvm_detect_profile
  ✓ nvm_do_install
  ✓ nvm_install_dir
  ✓ nvm_install_with_aliased_dot
  ✓ nvm_install_with_node_version
  ✓ nvm_profile_is_bash_or_zsh
  ✓ nvm_reset
  ✓ nvm_source

Looking at the travis I see that the nvm_check_if_path_exists test does not run here

sladyn98 avatar Mar 31 '21 08:03 sladyn98

ah, you'll need to chmod a+x test/install_script/nvm_check_if_path_exists so that it can be executed :-)

ljharb avatar Apr 03 '21 13:04 ljharb

I've rebased this, and marked it as a draft. Please mark it as ready for review when you think it's ready.

ljharb avatar Apr 15 '21 22:04 ljharb

@ljharb Do you want me to complete this ?

sladyn98 avatar Jun 25 '23 23:06 sladyn98

@sladyn98 that'd be ideal :-) but if you're not interested then it's fine to leave it open so someone else can pick it up.

ljharb avatar Jun 28 '23 16:06 ljharb