nvm icon indicating copy to clipboard operation
nvm copied to clipboard

Changed prefix check to work in case NVM_DIR is a link

Open GolanTrevize10 opened this issue 5 years ago • 4 comments

When NVM_DIR is a link, nvm mistakenly returns the error

nvm is not compatible with the npm config "prefix" option: currently set to "/data/jenkins-misc/nvm/versions/node/v8.10.0" Run npm config delete prefix or nvm use --delete-prefix v8.10.0 to unset it.

With this fix nvm will check correctly that the prefix is inside the NVM_DIR

GolanTrevize10 avatar Jan 10 '20 18:01 GolanTrevize10

Duplicate of #2045.

ljharb avatar Jan 11 '20 05:01 ljharb

@ljharb is there anything missing?

GolanTrevize10 avatar Feb 03 '20 12:02 GolanTrevize10

@GolanTrevize10 this is great, but it needs a test. can we add one?

ljharb avatar Feb 09 '20 20:02 ljharb

@GolanTrevize10 any chance you're able to add a test?

ljharb avatar Sep 29 '21 05:09 ljharb