nvim-treesitter-textobjects icon indicating copy to clipboard operation
nvim-treesitter-textobjects copied to clipboard

Improving julia queries

Open simonmandlik opened this issue 1 year ago • 1 comments

This is my best attempt to further improve julia queries:

  • works for empty structures
  • works for ; argument separation
  • adds @assignment.* queries

Queries are not perfect, there are still some limitations implied by the julia parser (for future reference: https://github.com/tree-sitter/tree-sitter-julia/issues/142)

simonmandlik avatar Jun 21 '24 21:06 simonmandlik

format-queries fails for me on

$ nvim -l ~/.local/share/nvim/lazy/nvim-treesitter/scripts/format-queries.lua ./queries/julia/textobjects.scm
E5113: Error while calling lua chunk: ...m/0.10.0/share/nvim/runtime/lua/vim/treesitter/query.lua:252: Query error at 163:17. Impossible pattern:
(anonymous_node (string) @format.keep)

simonmandlik avatar Jun 22 '24 09:06 simonmandlik

@kiyoon @ribru17 what can I do to merge this please? Tests are failing with some error that seems to not be caused by julia queries.

simonmandlik avatar Aug 01 '24 08:08 simonmandlik

is this rebased to the current master? Maybe that will fix the problems

kiyoon avatar Aug 01 '24 08:08 kiyoon

is this rebased to the current master? Maybe that will fix the problems

Yes it is

simonmandlik avatar Aug 01 '24 09:08 simonmandlik

I think people have been working on the R parser. Sorry for the delay but we'll need to wait a little

kiyoon avatar Aug 01 '24 09:08 kiyoon

format-queries fails for me on

Wrong parser version; make sure you install the query parser with nvim-treesitter (just like every bundled parser) to guarantee it's compatible. (Upgrading Nvim 0.10.1 should work, too, since I backported the update.)

I think people have been working on the R parser. Sorry for the delay but we'll need to wait a little

It's fixed now; please rebase on master.

clason avatar Aug 01 '24 15:08 clason

It's fixed now; please rebase on master.

Done, all tests pass now

simonmandlik avatar Aug 01 '24 22:08 simonmandlik