make the filename color like icon's color.

[singlexyz]

e.g. Make index.html filename part same to icon(orange).

[kyazdani42]

if this is done in a clean way i wouldn't be against it, although i think it's a little overkill and would probably conflict with other thing like git highlighting and lsp diagnostics. Also the renderer.lua is getting quite big and this feature would add another good amount of code in it, maybe splitting it beforehand would make it easier.

[alex-courtis]

#1131 adds colour for icons when not using nvim-web-devicons.

[alex-courtis]

Implemented!

[kyazdani42]

are you sure this feature request is not about changing the filename color ? i don't think it's implemented yet

[alex-courtis]

are you sure this feature request is not about changing the filename color ? i don't think it's implemented yet

My mistake. Apologies @singlexyz

[alex-courtis]

This is a nice Quality Of Life improvement.

[gegoune]

Would that not potentially interfere with git highlighting?

[alex-courtis]

Good point. We'd need to define and document a priority like diagnostic signs > git signs.

[gegoune]

@alex-courtis I believe priority will be implemented by yours #2455, won't it? Will your PR bring us closer to closing this issue? Is it even what we want at all (having external source (web-devicons) dictate colour of filename)?

[alex-courtis]

@alex-courtis I believe priority will be implemented by yours #2455, won't it? Will your PR bring us closer to closing this issue? Is it even what we want at all (having external source (web-devicons) dictate colour of filename)?

It will allow the user to always specify a highlight group for the icon and filename. Unfortunately it doesn't cover this functionality.

devicons.get_icon does return the highlight group for the icon which we apply to the icon and could apply to the filename. We could implement that in the overhaul or a separate change.