nvim-tree.lua
nvim-tree.lua copied to clipboard
nvim-tree
Collected Diagnostic Sign Issues
There are some issues with diagnostic sign visibility and correctness at fd2332a
Collect any bugs discovered in here.
I have seen some sporadic problems with signs not updating, however I have not been able to reproduce.
#1213 has been raised however has no reproducer
Update: not an nvim-tree bug
I think we could move the diagnostics update into the renderer actually, it'd be less inaccurate.
I think we could move the diagnostics update into the renderer actually, it'd be less inaccurate.
Yes.
Having the renderer able to render indicators in the signs column would be useful: we could then put other indicators e.g. git in there.
There are timing issues with diagnostics, that we don't see with other signs e.g. git. The diagnostics are often not updated until after the tree is rendered. This is a poor user experience.
We are able to handle git changes perfectly as we are reacting to all events that cause changes to git signs e.g. buffer writes. Diagnostics are lazy and late.
Improvement: Render the diagnostics upon change, rather than just on tree render. For nvim lsp we can use vim.lsp.diagnostic.on_publish_diagnostics For coc we can use the CocDiagnosticChange autocommand; there is no lua api
During this week, i've experienced a few diagnostics issues, using the default lsp diagnostics provided by neovim. I had to manually refresh the tree because the diagnostics where not updated. I'm not sure where this comes from, but i hope i can reproduce this more consistently.
I had to manually refresh the tree because the diagnostics where not updated
We are using the DiagnosticChanged for lsp updates. vim.lsp.diagnostic.on_publish_diagnostics may provide more consistent timings and perhaps even allow us to see atomic updates.
Coc has no option but the CocDiagnosticChange event.
@kyazdani42 Is this worked on, or a separate issue created? If it is not worked on, I think I can try to work on it because it is bothering me. :)
@kyazdani42 Is this worked on, or a separate issue created? If it is not worked on, I think I can try to work on it because it is bothering me. :)
#1430 added throttling (debouncing) and some additional safety to diagnostics.
Your assistance would be gratefully appreciated. Migration to vim.lsp.diagnostic.on_publish_diagnostics could prove very useful.
Diagnostics appear stable and are no longer causing performance issues as they are debounced.
Please raise a new bug report if you encounter any problems.