nvim-telescope
feat: adds-option-entryseparatorhl
Description
Adds option to configure the highlight of the result separator with new hl group: TelescopeResultsEntrySeparator
Fixes #3117
Type of change
Please delete options that are not relevant.
- New feature (non-breaking change which adds functionality)
How Has This Been Tested?
I've tested it by changing both the foreground and background of the new hlgroup: TelescopeResultsEntrySeparator
First test by changing the background:
:hi TelescopeResultsEntrySeparator guibg=#7f1425
Second test by changing the foreground:
:hi TelescopeResultsEntrySeparator guifg=#7f1425
Configuration:
- Neovim version (nvim --version): NVIM v0.10.0
- Operating system and version: win 11
Checklist:
- [X] My code follows the style guidelines of this project (stylua)
- [X] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation (lua annotations)
this now has a new behavior
now
before
i'm not sure i like it
I don't know if I like it more. Is there a cleaner way to allow users to change the separator highlight while keeping the actual default behaviour?
Is there a cleaner way to allow users to change the separator highlight while keeping the actual default behaviour?
but its not, we are losing the selected row highlighting because the selection is rendered before, i am not sure.
None the less for me it looks like a breaking change
I think the selection highlight is applied later after but the way extmark handles highlight combining is what's leading to this outcome.
There is a hl_mode option for nvim_buf_set_extmark that might be able to control this but it currently only works for virt_text extmarks. I don't have a good solution for this. Maybe it's not currently doable in a non-breaking change manner.
This doesn't affect me personally but I could see this being a pretty annoying breaking change to some.
