orgmode
orgmode copied to clipboard
feat/incorrect priority parsing
fixes #375
@jubnzv could you please take a look at this and see if it fixes the issue for you?
It's not perfect, as it does not address the issue of entering a multi-char string on the prompt when a numeric prio-scheme is active. That was not part of your original issue though
TODO:
- [ ] add unit tests
- [ ] unify input validation
- [ ] handle multi-char numerical input
Hi @jgollenz,
Thanks for the fix!
I found a minor issue, most likely it is not in your code. If you're trying to enter AA
in priorities prompt you'll get this error:
It will be great, if it is possible to make this message more user-friendly, removing the last line.
Otherwise it works fine. Thank you.
@jubnzv that was absolutely in my code. Forgot to push some changes, sorry. Should be fixed now.
@jgollenz It works. Thank you!
Fine with me, as long as we don't forget about it. Do you prefer TODO comments in the code or github issues?
You can add todo comments in the code. There are already a few of those in there.
@kristijanhusak ping :slightly_smiling_face: