orgmode icon indicating copy to clipboard operation
orgmode copied to clipboard

Fix wrong function access & output refile error

Open jgollenz opened this issue 3 years ago • 2 comments

fixes the bug mentioned in #311

  • refiling to a correct org-file with an incorrect headline resulted in an error, due to the function _refile_to_end being called with . instead of :
  • display an error message when trying to refile to a file that is not part of the files set in org_agenda_files
  • display an error message when trying to refile to a headline that is non-existent in the destination file

jgollenz avatar May 29 '22 11:05 jgollenz

This looks ok to me. Do you want to introduce any other changes or I can merge?

I'm still unsure what to do about that warning. As I said, it will never show, as it's immediately overwritten by the next log. IMO there should be no refiling when a user enters a non-existing headline. They clearly wanted to do something that cannot be fulfilled and our current output leaves them with the impression that their request was fulfilled, when in fact it was not. What is your opinion on this?

jgollenz avatar May 31 '22 21:05 jgollenz

@kristijanhusak I made the attempt to refile to a non-existent heading in an existing file an error. The users intention cannot be full-filled, so we should inform them about it and abort the action

jgollenz avatar Aug 07 '22 19:08 jgollenz