rocks.nvim icon indicating copy to clipboard operation
rocks.nvim copied to clipboard

luarocks packaging requests

Open mrcjkb opened this issue 1 year ago • 42 comments

[!NOTE]

🦥 This tracking issue is for the lazy and desperate 🦥

If you would like to actively contribute to getting plugins on luarocks.org, see this wiki page 🙏

Feel free to post your issues or PRs here.

Original text:

If you come across a plugin that isn't on luarocks.org, and you think it should be, you can leave a comment here (or thumbs up on any open PRs).

mrcjkb avatar Jan 14 '24 14:01 mrcjkb

Migrated most of my config to use rocks.nvim and found these plugins to be missing from luarocks:

glindstedt avatar Mar 31 '24 19:03 glindstedt

  • https://github.com/nvim-neorg/neorg-telescope/pull/54
  • https://github.com/lukas-reineke/lsp-format.nvim/pull/83
  • https://github.com/lewis6991/gitsigns.nvim/pull/964
  • https://github.com/romgrk/barbar.nvim/pull/566
  • https://github.com/tummetott/unimpaired.nvim/pull/7
  • https://github.com/nvimtools/none-ls.nvim/pull/103
  • https://github.com/kevinhwang91/nvim-ufo/pull/211
  • https://github.com/nvim-neotest/neotest-go/pull/88
  • https://github.com/mg979/vim-visual-multi/pull/262

mrcjkb avatar Apr 01 '24 19:04 mrcjkb

Just found this issue and I found that rktjmp/hotpot.nvim is missing from luarocks.

datwaft avatar Apr 02 '24 01:04 datwaft

Just found this issue and I found that rktjmp/hotpot.nvim is missing from luarocks.

I'm going to wait for https://github.com/nvim-neorocks/rocks.nvim/pull/236, because ~hotpot.nvim would need to be installed with opt=true and loaded manually, using require("rocks").packadd(...).~

  • https://github.com/rktjmp/hotpot.nvim/pull/135

mrcjkb avatar Apr 02 '24 22:04 mrcjkb

https://github.com/nvim-neo-tree/neo-tree.nvim

Found this one today that is missing a luarocks package, last one I need for my config!

zackerydev avatar Apr 12 '24 14:04 zackerydev

  • https://github.com/nvim-neo-tree/neo-tree.nvim/pull/1434

mrcjkb avatar Apr 13 '24 14:04 mrcjkb

I would love to have this one to make some extensions for rocks.nvim like a rocks-ui.nvim module and easily write the UI/UX with it, nui.nvim is already on luarocks so it shouldn't take so long :p

NTBBloodbath avatar Apr 13 '24 17:04 NTBBloodbath

  • https://github.com/grapp-dev/nui-components.nvim/pull/22

mrcjkb avatar Apr 13 '24 21:04 mrcjkb

https://github.com/freddiehaddad/feline.nvim ?

Anrock avatar Apr 18 '24 13:04 Anrock

  • https://github.com/freddiehaddad/feline.nvim/pull/71

mrcjkb avatar Apr 18 '24 18:04 mrcjkb

molten-nvim

but, it's a remote python plugin with a few python dependencies, so I haven't done it myself. I'm not sure if you have any advice on this? If there's going to be a lot of discussion we can move somewhere else to not pollute this thread.

benlubas avatar Apr 19 '24 18:04 benlubas

molten-nvim

but, it's a remote python plugin with a few python dependencies, so I haven't done it myself. I'm not sure if you have any advice on this? If there's going to be a lot of discussion we can move somewhere else to not pollute this thread.

  • [ ] Looks like a nice challenge. I think it might need a luarocks python/venv build backend (for handling python dependencies), which doesn't seem to exist yet.

mrcjkb avatar Apr 21 '24 16:04 mrcjkb

https://github.com/Olical/conjure would be lovely :)

benjstephenson avatar May 01 '24 04:05 benjstephenson

These would be helpful:

https://github.com/nvim-telescope/telescope-fzf-native.nvim https://github.com/nvim-telescope/telescope-fzy-native.nvim https://github.com/natecraddock/telescope-zf-native.nvim

calebeby avatar May 22 '24 03:05 calebeby

  • https://github.com/Olical/conjure/pull/579
  • https://github.com/nvim-telescope/telescope-fzf-native.nvim/pull/127
  • https://github.com/natecraddock/telescope-zf-native.nvim/pull/19

telescope-fzy-native.nvim uses submodules to depend on fzy-lua-native. fzy-lua-native is packaged in a very weird way, without any regard for potential module naming clashes (e.g. a lua/native.lua file, wtf?). I don't think it makes sense to attempt to package that. A better alternative might be to rewrite telescope-fzy-native.nvim, so that it depends on fzy, which is packaged properly, instead.

mrcjkb avatar May 23 '24 21:05 mrcjkb

treesj is already on luarocks, but its dependency should be updated. nvim-treesitter should be removed from dependency^1.

boltlessengineer avatar May 26 '24 06:05 boltlessengineer

Some I've come across as I'm moving away from Lazy.nvim to rocks.nvim (huge thanks for this btw, I love the simplicity and thought behind it):

https://github.com/ggandor/leap.nvim https://github.com/ggandor/flit.nvim https://github.com/glacambre/firenvim

craigmac avatar Jun 03 '24 15:06 craigmac

@boltlessengineer Updated :smile:

@craigmac sorry for taking so long to respond. I hope to get back to this soon :sweat_smile:

Update:

  • https://github.com/ggandor/leap.nvim/pull/234 [added to NURR for now]

  • https://github.com/ggandor/flit.nvim/pull/51 [added to NURR for now]

  • [ ] firenvim is going to be a challenge, because it uses an autoload function to install. For luarocks, this might require a Makefile/Makefile.win that starts Neovim, loads the plugin, and executes the function.

mrcjkb avatar Jun 17 '24 22:06 mrcjkb

Thanks a lot for all the work on this. I'd like to request these:

  • https://github.com/folke/ts-comments.nvim
  • https://github.com/rafamadriz/friendly-snippets
  • https://github.com/garymjr/nvim-snippets
  • https://github.com/MeanderingProgrammer/markdown.nvim

Also, I saw you've been working on getting cmp to update its releases so hopefully the maintainer will notice soon. Thanks!

EDIT: @mrcjkb Thanks for publishing these plugins. One thing on the friendly-snippets package: I'm not seeing the "snippets" directory which contains all the snippets it provides on my machine after installing the plugin.

simifalaye avatar Jun 24 '24 20:06 simifalaye

One thing on the friendly-snippets package: I'm not seeing the "snippets" directory which contains all the snippets it provides on my machine after installing the plugin.

Ah, that's not a standard neovim directory. I guess I'll have to open a PR to friendly-snippets then.

mrcjkb avatar Jul 02 '24 15:07 mrcjkb

@simifalaye friendly-snippets should be fixed now.

mrcjkb avatar Jul 03 '24 19:07 mrcjkb

@mrcjkb Any news on markdown.nvim?

Also, I saw that the gitsigns PR was merged but it's just waiting for a new release to be made?

Thanks very much for all your work, you are a machine!

simifalaye avatar Jul 15 '24 17:07 simifalaye

Could you possibly help out with benlubas/neorg-se?

It's a plugin that bundles a rust binary using mlua and the luarocks-build-rust-mlua backend. I've been unsuccessful so far in getting lazy to install and build it. I can install with luarocks --local --lua-version 5.1 install neorg-se without errors. But even that doesn't seem like it's building the rust module, and I don't see the libneorg_se.so file that I expect to see anywhere in ~/.luarocks or ~/.local/share/nvim/lazy(-rocks)

relevant part of error:
Error: Failed initializing build back-end for build type 'rust-mlua': module 'luarocks.build.rust-mlua' not found:
      	No LuaRocks module found for luarocks.build.rust-mlua
      	no field package.preload['luarocks.build.rust-mlua']
      	no file '/opt/homebrew/Cellar/luarocks/3.9.2/share/lua/5.4/luarocks/build/rust-mlua.lua'
      	no file '/opt/homebrew/share/lua/5.4/luarocks/build/rust-mlua.lua'
      	no file '/opt/homebrew/share/lua/5.4/luarocks/build/rust-mlua/init.lua'
      	no file '/opt/homebrew/lib/lua/5.4/luarocks/build/rust-mlua.lua'
      	no file '/opt/homebrew/lib/lua/5.4/luarocks/build/rust-mlua/init.lua'
      	no file './luarocks/build/rust-mlua.lua'
      	no file './luarocks/build/rust-mlua/init.lua'
      	no file '/Users/benlubas/.luarocks/share/lua/5.4/luarocks/build/rust-mlua.lua'
      	no file '/Users/benlubas/.luarocks/share/lua/5.4/luarocks/build/rust-mlua/init.lua'
      	no file '/opt/homebrew/lib/lua/5.4/luarocks/build/rust-mlua.so'
      	no file '/opt/homebrew/lib/lua/5.4/loadall.so'
      	no file './luarocks/build/rust-mlua.so'
      	no file '/Users/benlubas/.luarocks/lib/lua/5.4/luarocks/build/rust-mlua.so'
      	no file '/opt/homebrew/lib/lua/5.4/luarocks.so'
      	no file '/opt/homebrew/lib/lua/5.4/loadall.so'
      	no file './luarocks.so'
      	no file '/Users/benlubas/.luarocks/lib/lua/5.4/luarocks.so'
      luarocks-build-rust-mlua dev-1 is now installed in /Users/benlubas/random/neorg_se_install_bug/.repro/data/nvim/lazy-rocks/neorg-se (license: MIT)

benlubas avatar Jul 15 '24 18:07 benlubas

I'm away from my laptop this week.

Any news on markdown.nvim?

I'm planning on publishing the tree-sitter parsers with 0-ver versions (in anticipation nvim-treesitter going semver one day). When that is done, markdown.nvim can add them as a dependency. If it depended on the current dev packages, it wouldn't be possible to install a non-dev version of markdown.nvim.

Edit:

  • https://github.com/MeanderingProgrammer/markdown.nvim/pull/78

mrcjkb avatar Jul 16 '24 07:07 mrcjkb

Could you possibly help out with benlubas/neorg-se?

I can see if it works with rocks.nvim when I'm back on my laptop.

It looks like whatever lazy.nvim is using to install it can't find the luarocks-build-rust-mlua build backend, which could have something to do with how lazy.nvim installs dependencies and rocks into separate trees (iirc; not sure about this).

You could try working around this by installing luarocks-build-rust-mlua locally: luarocks --local install luarocks-build-rust-mlua

mrcjkb avatar Jul 16 '24 08:07 mrcjkb

Thank you, that did allow me to install it! I can get another rocks.nvim user to test it for me so don't worry about that. thank you for the suggestion!

benlubas avatar Jul 16 '24 14:07 benlubas

This would be great: https://github.com/creativenull/efmls-configs-nvim

simifalaye avatar Jul 19 '24 19:07 simifalaye

would love to see https://github.com/udayvir-singh/tangerine.nvim and https://github.com/udayvir-singh/hibiscus.nvim :)

vimproved avatar Jul 21 '24 01:07 vimproved

@simifalaye

  • https://github.com/nvim-neorocks/nurr/pull/20

@vimproved I'll look into opening some PRs. By the looks of it, bootstrapping would be unnecessary with rocks.nvim.

Edit:

  • https://github.com/udayvir-singh/tangerine.nvim/pull/36 [added to NURR for now]
  • https://github.com/udayvir-singh/hibiscus.nvim/pull/18 [added to NURR for now]

Added both plugins to the NURR for now.

mrcjkb avatar Jul 21 '24 12:07 mrcjkb

firenvim is going to be a challenge, because it uses an autoload function to install.

Do you mean call firenvim#install(0)? Every time we install a new browser, it should be execute to let it find it. Maybe we don't need to ru this function during installing, and let user do it when they install a browser.

nvim-treesitter going semver one day

nvim-treesitter disappear from luarocks. Anyone know what happened?

Freed-Wu avatar Jul 22 '24 16:07 Freed-Wu