neorg icon indicating copy to clipboard operation
neorg copied to clipboard

Fixed tree-sitter-norg parser builds on MacOS.

Open pcekm opened this issue 1 year ago • 3 comments

  • Added use_makefile, which is how nvim-treesitter builds the norg parser by default and which correctly adds the required compiler flags
  • Removed a macOS build kludge that is no longer needed (and seems not to work anymore)
  • Removed branch specification which is ignored when setting revision.

Tested on an Apple silicon machine running macOS 14.7, and an Intel machine running macOS running macOS 13.7.

Fixes nvim-neorg/tree-sitter-norg#45

pcekm avatar Sep 29 '24 00:09 pcekm

Hey I think you're changes are already covered in this PR

zerachiel016 avatar Oct 05 '24 18:10 zerachiel016

#1020 is stalled though, I could see merging this in the meantime.

benlubas avatar Oct 05 '24 19:10 benlubas

FWIW, I got a clean build with this PR on an M3 MacBook running MacOS 15, and also on an x86_64 laptop running Linux Mint.

wjyoung65 avatar Oct 12 '24 02:10 wjyoung65

This is a must have! Compiled without issues on Neorg 9.2.0 and Intel MacOS 14.7.4.

saxon1964 avatar Mar 25 '25 22:03 saxon1964