lualine.nvim icon indicating copy to clipboard operation
lualine.nvim copied to clipboard

Migrate `vim.loop` to `vim.uv`

Open hinell opened this issue 8 months ago • 5 comments

See neovim/neovim/pull/22846

Affected files:

lua/lualine/components/branch/git_branch.lua
lua/lualine/components/hostname.lua
lua/lualine/utils/utils.lua

Please, keep these vim.loop.* calls by condition using has("nvim-0.9") == 1 to ensure backwards compatibility

hinell avatar Oct 06 '23 18:10 hinell

What is the point of this issue? vim.loop will not be removed anytime soon, so there's zero need to change anything here.

clason avatar Oct 18 '23 07:10 clason

Obviously we will remove it at some point, but that point is far off -- there isn't even a formal deprecation notice for it in 0.10. So both the request in your issue title and the concern in your issue body (which are contradictory, btw) are very premature.

clason avatar Oct 18 '23 14:10 clason

@clason Is there specific neovim policy on features removal?

Recently, I've wasted 3 hours fixing lsp.get_active_clients() calls in my lsp-timeout.nvim plugin.. Just want to ensure that my plugin setup is stable.

I've seen previously statements like this one, so I thought that it might get removed in the next few versions: https://github.com/neovim/neovim/blob/c49cfd89fdd32d670c484b0b677bc8647e891a12/runtime/lua/vim/lsp.lua#L2069-L2072

the request in your PR title he concern in your PR bod

This is not PR, consider this as a tracking issue.

hinell avatar Oct 18 '23 14:10 hinell

It will get removed in a future version, but not in the next one (or the one after that). So this issue is premature.

(Also, why did you fix these calls? They will still work fine in 0.10; the notice will be added in 0.11 and only removed in 0.12. That's year(s) away.)

clason avatar Oct 18 '23 14:10 clason

Also, why did you fix these calls?

Backwards compatibility. Some package registries still ship old nvim. I'm using nightly version though, but anyway...

Checkout my plugin btw, you will love it.

hinell avatar Oct 18 '23 14:10 hinell