kickstart.nvim icon indicating copy to clipboard operation
kickstart.nvim copied to clipboard

Conform breaking change

Open SebasF1349 opened this issue 1 year ago • 3 comments

Describe the bug

Conform.nvim has just introduced a breaking change. This is the commit: https://github.com/stevearc/conform.nvim/commit/9228b2ff4efd58b6e081defec643bf887ebadff6

It seems that the only thing kickstart needs to update is the keymap and change

require('conform').format { async = true, lsp_fallback = true }

(https://github.com/nvim-lua/kickstart.nvim/blob/master/init.lua#L635)

with require('conform').format { async = true, lsp_format = "fallback" }

To Reproduce

  1. Just update conform.nvim (doesn't seem to crash kickstart, but probably the fallback won't work).

Desktop

  • OS: Ubuntu (WSL)
  • Terminal: Wezterm

Neovim Version

Nightly

SebasF1349 avatar Jun 17 '24 14:06 SebasF1349

I can make a pr if you want.

SebasF1349 avatar Jun 17 '24 14:06 SebasF1349

Per https://github.com/stevearc/conform.nvim/pull/456#issuecomment-2178715893 this should be fixed in the latest version - can you confirm?

rmacklin avatar Jun 19 '24 23:06 rmacklin

Will test later on home, but in any case even if the fallback works lsp_fallback has been deprecated and shouldn't be in the config. Change should be made, although it can wait for now just to be backwards compatible with people that hasn't updated yet.

SebasF1349 avatar Jun 19 '24 23:06 SebasF1349

Fixed in latest conform. Closing.

feoh avatar Jul 22 '24 02:07 feoh