kickstart.nvim icon indicating copy to clipboard operation
kickstart.nvim copied to clipboard

Added the options to change default orange color, and duration of the highlight-on-yank autocommand

Open dezly-macauley opened this issue 11 months ago • 8 comments

Those who are new to Neovim will be easily able to change the color of the highlight (if they don't like the default orange flash).

There are two local variables that can be used to change the color of the highlight and the duration of the highlight.

I've been using this auto command for months now, without any bugs or clashes with UI plugins.

I've tried to keep this as close to lua as possible, while making sure that this pull request is properly formatted using stylua

dezly-macauley avatar Mar 07 '24 16:03 dezly-macauley

Please note, use stylua

brxxlstxrs avatar Mar 07 '24 17:03 brxxlstxrs

I'm not sure why I keep failing the stylua test. I'm using the conform nvim configuration from this kickstart.nvim repo

-------- Original Message -------- On Mar 7, 2024, 7:18 PM, brxxlstxrs wrote:

Please note, use stylua

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

dezly-macauley avatar Mar 07 '24 17:03 dezly-macauley

I'm not sure why I keep failing the stylua test. I'm using the conform nvim configuration from this kickstart.nvim repo -------- Original Message -------- On Mar 7, 2024, 7:18 PM, brxxlstxrs wrote: Please note, use stylua — Reply to this email directly, [view it on GitHub](#722 (comment)), or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

see stylua check errors

brxxlstxrs avatar Mar 07 '24 20:03 brxxlstxrs

I'm not sure why I keep failing the stylua test. I'm using the conform nvim configuration from this kickstart.nvim repo -------- Original Message -------- On Mar 7, 2024, 7:18 PM, brxxlstxrs wrote: Please note, use stylua — Reply to this email directly, [view it on GitHub](#722 (comment)), or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

see stylua check errors

How do I do that? I am on Linux. Do I need to have stylua installed on my system?

Is this something I check in Neovim or on an OS level

dezly-macauley avatar Mar 08 '24 19:03 dezly-macauley

I'm not sure why I keep failing the stylua test. I'm using the conform nvim configuration from this kickstart.nvim repo -------- Original Message -------- On Mar 7, 2024, 7:18 PM, brxxlstxrs wrote: Please note, use stylua — Reply to this email directly, [view it on GitHub](#722 (comment)), or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

see stylua check errors

How do I do that? I am on Linux. Do I need to have stylua installed on my system?

Is this something I check in Neovim or on an OS level

not necessary, you can look at the details of a specific error check on Github, it already shows everything

brxxlstxrs avatar Mar 08 '24 20:03 brxxlstxrs

I'm not sure why I keep failing the stylua test. I'm using the conform nvim configuration from this kickstart.nvim repo -------- Original Message -------- On Mar 7, 2024, 7:18 PM, brxxlstxrs wrote: Please note, use stylua — Reply to this email directly, [view it on GitHub](#722 (comment)), or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

see stylua check errors

How do I do that? I am on Linux. Do I need to have stylua installed on my system? Is this something I check in Neovim or on an OS level

not necessary, you can look at the details of a specific error check on Github, it already shows everything

I have sorted out the stylua errors. All checks have been passed. Had to install stylua manually on my system because mason.nvim and NixOS don't get along.

dezly-macauley avatar Mar 08 '24 20:03 dezly-macauley

Recommend use ' nor " (in style like @tjdevries, it won't create problems)

brxxlstxrs avatar Mar 09 '24 05:03 brxxlstxrs

Recommend use ' nor " (in style like @tjdevries, it won't create problems)

I believe the stylua formatting from my last commit has already made this change. I checked again. Single quotes are being used. Let me know if there's anything else that needs to be done.

dezly-macauley avatar Mar 09 '24 10:03 dezly-macauley

Hi.

Sorry to rain on your parade a bit but our long standing position has been that you can theme yourself blue but please do it in your own fork.

Kickstart's goal is to provide a reasonable set of defaults for new folks, and creating a bunch of new extension points increases sprawl and may add confusion for new folks.

I'm closing this for now, but thank you for your contribution in any case!

feoh avatar Mar 12 '24 14:03 feoh

Hey thanks for taking the time to review my contribution. This is my first time contributing to open source, so I'm kinda disappointed that it wasn't accepted.

However I understand the reason, and why my contribution may not fit the intended objective / goals of kickstart nvim.

Nonetheless I have learned a lot and look forward to contributing again in the future. 😎✌️

-------- Original Message -------- On Mar 12, 2024, 4:35 PM, Chris Patti wrote:

Hi.

Sorry to rain on your parade a bit but our long standing position has been that you can theme yourself blue but please do it in your own fork.

Kickstart's goal is to provide a reasonable set of defaults for new folks, and creating a bunch of new extension points increases sprawl and may add confusion for new folks.

I'm closing this for now, but thank you for your contribution in any case!

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

dezly-macauley avatar Mar 13 '24 13:03 dezly-macauley

I am sincerely delighted to hear that!

And I encourage you to create a fork and run with your change there. I do this as I have a number of things in my setup that don't jive well with kickstart mainline.

feoh avatar Mar 13 '24 13:03 feoh