kickstart.nvim icon indicating copy to clipboard operation
kickstart.nvim copied to clipboard

Published 20 hours ago • verified publisher icon nvim-lua

feat: added contexts for code action - source fix-all errors

Open micaiah-effiong opened this issue 1 year ago • 3 comments

This PR helps resolve unused imports and function refactors from code action

micaiah-effiong avatar Jan 26 '24 01:01 micaiah-effiong

Hi. Thanks for your contribution!

  1. Please give detailed steps on how you tested this.
  2. Do you see any potential for this breaking people's customizations or configurations?

feoh avatar Jan 29 '24 18:01 feoh

Also, sorry for all the questions, but where are you seeing a warning please? I don't see any warnings in either neovim itself or when I run luacheck on init.lua

feoh avatar Jan 29 '24 19:01 feoh

@Userbotantonio Hi we can't help you debug your termux issues here. Please talk to the folks who run the Termux project.

Hope the translator got that right, I don't speak Spanish :)

feoh avatar Jan 30 '24 15:01 feoh

Hi. While I don't see anything particularly wrong with this PR I don't understand what problem we're fixing as I can't reproduce the warning @micaiah-effiong cited and the activity from @Userbotantonio feels spam/bot/malware to me.

I'd love others feedback/thoughts on this, and @micaiah-effiong if you're reading this at all I'd love an answer to my questions please :)

Otherwise I'm going to close this in a day or two.

feoh avatar Jan 30 '24 15:01 feoh

I can't make heads or tails of what's going on with this pull request, so I'm closing it.

If someone from the community who speaks Spanish can tell me what's going on and how it related to kickstart.nvim please feel free to re-open :)

Thanks!

feoh avatar Jan 30 '24 20:01 feoh

@feoh sorry for the late response.

Hi. Thanks for your contribution!

  1. Please give detailed steps on how you tested this.
  2. Do you see any potential for this breaking people's customizations or configurations?
  1. I had issues with some LSPs not being able to remove all unused imports, leading to manually removing them. This was supposed to resolve that.
  2. I tested the update with other LSPs (go, rust, and even tsserver) and it did not break.

I think I can still keep this as a reference for anyone who has issues removing all unused imports using code action.

micaiah-effiong avatar Feb 02 '24 20:02 micaiah-effiong

No problem, thanks for the response! Unfortunately, I don't speak Spanish, and Google translate only goes so far :)

This change looks reasonable to me, and by now anyone who had issues would have commented, so I'll merge it. Thanks!

feoh avatar Feb 02 '24 20:02 feoh

@Userbotantonio, Creo que estás en el repositorio equivocado.

I think he is in the wrong repository.

micaiah-effiong avatar Feb 02 '24 20:02 micaiah-effiong