nvaccess
Fix me please!
compoundDocuments.py ln 146: field["table-id"] = 1 # FIXME What's the fixMe about? I'm probably gonna need this for Libre table nav.
Could you please do a git blame on that so we know when and who it came from? Mention them on this issue and hopefully they remember what its about.
It was me. In short, we didn't have a major need for the table id in soffice before, so I took a shortcut.
For the table cell case, you can just use obj.tableID. For the table case, it's a bit trickier because obj.tableID currently doesn't work on the table itself. We can probably change the IAccessible tableID property to check whether self is a table object and also return an id in that case.
By "An ID, what exactly should be returned? Is there some kind of Unique ID property or thing? there's two tuples returned by tableID generally from my experiments.
On 1/10/2017 4:56 PM, James Teh wrote:
It was me. In short, we didn't have a major need for the table id in soffice before, so I took a shortcut.
For the table cell case, you can just use obj.tableID. For the table case, it's a bit trickier because obj.tableID currently doesn't work on the table itself. We can probably change the IAccessible tableID property to check whether self is a table object and also return an id in that case.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nvaccess/nvda/issues/6714#issuecomment-271736341, or mute the thread https://github.com/notifications/unsubscribe-auth/AFGivUkl6ip6iKbcD_PaSBSD6O--xYLCks5rRBqkgaJpZM4LfF_q.
--
Derek Riemer
- Department of computer science, third year undergraduate student.
- Proud user of the NVDA screen reader.
- Open source enthusiast.
- Member of Bridge Cu
- Avid skiier.
Websites: Honors portfolio http://derekriemer.com Awesome little hand built weather app! http://django.derekriemer.com/weather/
email me at [email protected] mailto:[email protected] Phone: (303) 906-2194
Look at the tableID property in NVDAObjects.IAccessible.IAccessible. You'd just be modifying that code to return a tableID for the table itself (not just for table cells).
Look at the tableID property in NVDAObjects.IAccessible.IAccessible. You'd just be modifying that code to return a tableID for the table itself (not just for table cells).
I see a .table property, but libre's table yields None for it. Is this a bug in the table property code? there's an IAccessibleTableObject on the table object, which means I think we should generate a table object?
Is this line intentional on 1140 of the IAccessible/iit?
while checkAncestors and obj and not hasattr(obj,'IAccessibleTableObject'): parent=obj.parent=obj.parent #The buggy line
This code seems a bit scatter brained to me, can I change it to first check myself if I'm a table, and then check my parents?
On 1/11/2017 3:38 PM, James Teh wrote:
Look at the tableID property in NVDAObjects.IAccessible.IAccessible. You'd just be modifying that code to return a tableID for the table itself (not just for table cells).
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nvaccess/nvda/issues/6714#issuecomment-272018335, or mute the thread https://github.com/notifications/unsubscribe-auth/AFGivWi-3Ix71IM-QNBukNVi83jxZ5brks5rRVnlgaJpZM4LfF_q.
--
Derek Riemer
- Department of computer science, third year undergraduate student.
- Proud user of the NVDA screen reader.
- Open source enthusiast.
- Member of Bridge Cu
- Avid skiier.
Websites: Honors portfolio http://derekriemer.com Awesome little hand built weather app! http://django.derekriemer.com/weather/
email me at [email protected] mailto:[email protected] Phone: (303) 906-2194
@derekriemer Are you still working on this? I'll assign it to you now, please unassign yourself if you are not.
@michaelweghorn I think this is related to Libreoffice and table navigation with NVDA, using ctrl+alt+arrow keys, I think @derekriemer wanted to implement this but encountered this issue. Maybe you can provide some insights / contributions from LO side on this, see the comments above.
@michaelweghorn I think this is related to Libreoffice and table navigation with NVDA, using ctrl+alt+arrow keys, I think @derekriemer wanted to implement this but encountered this issue. Maybe you can provide some insights / contributions from LO side on this, see the comments above.
My assumption/expectation would generally be that the IAccessibleTable/IAccessibleTable2/IAccessibleTableCell interfaces should be providing what's needed for table navigation. See also: #4133 If anything is missing or not working as expected on LibreOffice side, please let me know and I'll take a look.
From how I read the conversation in this issue so far, it seems to be mostly about NVDA code, however. Or is anything known to be missing on LO side already?
