nvda icon indicating copy to clipboard operation
nvda copied to clipboard

Use fixed width font in the log viewer and the Python console

Open CyrilleB79 opened this issue 11 months ago • 2 comments

Link to issue number:

None

Summary of the issue:

Errors in the source code are indicated visually by "^" characters and has become more precise with Python 3.11. However, the characters used in log viewer or python console have not a fixed width so:

  • visually, the wrong place of the source code is indicated
  • for blind people, going on the error marker ("^" characters) and pressing upArrow to jump at the same column position in the source code's line is useless because the cursor does not land in the same column.

Description of user facing changes

Use a fixed width font in the log viewer and in the Python console. In the Python console, only the output field is impacted by vertical alignment considerations; however, for visual consistency I have modified both the input and the output fields.

Description of development approach

Change the log viewer's font to 'Consolas' which has fixed width and which is the one used in Notepad.

Testing strategy:

Manual tests:

  • Tested visually that the log viewer and the python console is using a fixed width.
  • Tested that vertical navigation is OK from error markers in a traceback
  • [ ]: Test required from a sighted person. (cc @Qchristensen or @gerald-hartig ?) to check the general appearance of the log viewer and python console for which I am not relevant.

Known issues with pull request:

None.

Code Review Checklist:

  • [x] Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • [x] Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • [x] UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • [x] API is compatible with existing add-ons.
  • [x] Security precautions taken.

CyrilleB79 avatar Mar 18 '24 22:03 CyrilleB79

The build can be downloaded here.

I would like to have a visual feedback of this new appearance of the log viewer before passing this PR to ready. @Qchristensen, @gerald-hartig or anyone else sighted, would you mind provide a visual confirmation? Thanks.

CyrilleB79 avatar Mar 20 '24 20:03 CyrilleB79

@Qchristensen or @gerald-hartig, could you please provide a visual feedback running this build, looking at the log viewer and the Python console?

Or I may provide screenshots if you want, hoping that the resolution of the picture will be OK. Let me know.

CyrilleB79 avatar Apr 15 '24 09:04 CyrilleB79

This PR is ready on my side. Adding Quentin or Gerald as reviewers to have a visual feedback.

CyrilleB79 avatar May 02 '24 14:05 CyrilleB79

The new font looks good to me, happy to hear what @gerald-hartig and @Qchristensen think as well

seanbudd avatar May 06 '24 05:05 seanbudd

Test build: https://ci.appveyor.com/api/buildjobs/yvcqxx5o6nml3djr/artifacts/output%2Fnvda_snapshot_pr16321-31597%2C43c6c390.exe

seanbudd avatar May 06 '24 05:05 seanbudd

Looks good to me. Thanks for the link to the snapshot build @seanbudd

gerald-hartig avatar May 06 '24 21:05 gerald-hartig

  • Build execution time has reached the maximum allowed time for your plan (60 minutes).

See test results for failed build of commit df3c55c751

AppVeyorBot avatar May 07 '24 08:05 AppVeyorBot