Support HTML Figures in Chromium

[SaschaCowley]

Link to issue number:

Fixes #16137

Summary of the issue:

Figures are currently not properly announced in browse or focus modes by NVDA.

Description of user facing changes

Figures are now reported in Chrome.

Description of development approach

Since Chromium does not report a role of figure on <figure> elements unless the role has been added, add tests for a tag of figure in virtual buffers and in IA2 web controls.

Testing strategy:

Manual tests with a test webpage.

Known issues with pull request:

None yet.

Code Review Checklist:

• [ ] Documentation:
  • Change log entry
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• [ ] Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• [x] UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• [x] API is compatible with existing add-ons.
• [x] Security precautions taken.

[AppVeyorBot]

• PASS: Translation comments check.
• PASS: Unit tests.
• FAIL: Lint check. See test results for more information.
• PASS: System tests (tags: installer NVDA).
• Build (for testing PR): https://ci.appveyor.com/api/buildjobs/t7paj6pear6wp87o/artifacts/output/nvda_snapshot_pr16206-31128,a72df41a.exe
• CI timing (mins): INIT 0.0, INSTALL_START 1.1, INSTALL_END 1.0, BUILD_START 0.0, BUILD_END 30.0, TESTSETUP_START 0.0, TESTSETUP_END 0.4, TEST_START 0.0, TEST_END 2.4, FINISH_END 0.2

See test results for failed build of commit a72df41a91

[AppVeyorBot]

• PASS: Translation comments check.
• PASS: Unit tests.
• FAIL: Lint check. See test results for more information.
• PASS: System tests (tags: installer NVDA).
• Build (for testing PR): https://ci.appveyor.com/api/buildjobs/2891l3c5y9dna48b/artifacts/output/nvda_snapshot_pr16206-31298,ae04cade.exe
• CI timing (mins): INIT 0.0, INSTALL_START 1.1, INSTALL_END 1.0, BUILD_START 0.0, BUILD_END 28.9, TESTSETUP_START 0.0, TESTSETUP_END 0.4, TEST_START 0.0, TEST_END 2.3, FINISH_END 0.2

See test results for failed build of commit ae04cadee1

[AppVeyorBot]

• PASS: Translation comments check.
• PASS: Unit tests.
• FAIL: Lint check. See test results for more information.
• FAIL: System tests (tags: installer NVDA). See test results for more information.
• Build (for testing PR): https://ci.appveyor.com/api/buildjobs/2o4l9ha831je9lh1/artifacts/output/nvda_snapshot_pr16206-31312,1fb40c1c.exe
• CI timing (mins): INIT 0.0, INSTALL_START 1.0, INSTALL_END 0.9, BUILD_START 0.0, BUILD_END 29.1, TESTSETUP_START 0.0, TESTSETUP_END 0.2, TEST_START 0.0, TEST_END 0.7, FINISH_END 0.2

See test results for failed build of commit 1fb40c1c47

[AppVeyorBot]

• PASS: Translation comments check.
• PASS: Unit tests.
• PASS: Lint check.
• FAIL: System tests (tags: installer NVDA). See test results for more information.
• Build (for testing PR): https://ci.appveyor.com/api/buildjobs/412b1h1ffxra7m34/artifacts/output/nvda_snapshot_pr16206-31322,ee6178bb.exe
• CI timing (mins): INIT 0.0, INSTALL_START 1.1, INSTALL_END 0.9, BUILD_START 0.0, BUILD_END 29.5, TESTSETUP_START 0.0, TESTSETUP_END 0.3, TEST_START 0.0, TEST_END 0.8, FINISH_END 0.2

See test results for failed build of commit ee6178bbfd

[SaschaCowley]

Thanks @SaschaCowley. As the testing field is unticked, can you confirm you've tested this?

This has been manually tested. The initial PR comment has been updated to reflect this.