nvaccess
No longer reinit hwIo on config reset
Link to issue number:
Related to #15833 Might improve #14872
Summary of the issue:
When moving the hwIo background thread from braille to hwIo, core.resetConfiguration was changed to reinitialize hwIo. However since hwIo has nothing to do with config at all, there is no need to do so.
Description of user facing changes
Might improve #14872
Description of development approach
No longer reload hwIo.
Testing strategy:
Ensured that reloading config still works.
Known issues with pull request:
None known
Code Review Checklist:
- [ ] Documentation:
- Change log entry
- User Documentation
- Developer / Technical Documentation
- Context sensitive help for GUI changes
- [ ] Testing:
- Unit tests
- System (end to end) tests
- Manual testing
- [x] UX of all users considered:
- Speech
- Braille
- Low Vision
- Different web browsers
- Localization in other languages / culture than English
- [x] API is compatible with existing add-ons.
- [x] Security precautions taken.
@CyrilleB79 Could you have a try with this pr to see whether #14872 improves?
I have tested this PR yesterday or today:
- Sometimes NVDA+control+R works
- Sometimes it crashes NVDA But I have not been able to have an error in the log.
On the contrary, with #15833 or just with last alpha, upon NVDA+R:
- either config re-initialization works
- or NVDA crashes with no error in the log
- or NVDA freezes (and maybe crashes later) with an error in the log such as the ones indicated in #15833 or in #14872
If you want, I may try to make more attempts to get an error with the current PR next week.
@LeonarddeR what is the status on this PR? Are you still intending to work on it?
No, according to my last test (https://github.com/nvaccess/nvda/pull/15849#issuecomment-1836564312), it does not fix anything unfortunately.
