nvda
nvda copied to clipboard
Enable rdp via appveyor settings
Link to issue number:
Related to #13983
Summary of the issue:
Sometimes the Appveyor environment is unpredictable, recently Docker Desktop opens a window asking for feedback. This window takes the foreground which subsequently results in applications started from the system test being unable to take focus back.
Description of user facing changes
For developers: The intention is to fix this foreground issue separately, which may take some time. Until then, and for other issues in the future, make it easier to enable RDP as required.
The details of the connection show in the build log at the start of the build (after cloning NVDA)
Description of development approach
When the environment variable for an RDP password is set (via the Appveyor settings), the appveyor RDP script will be run. NV Access developers will need to set (and unset) this environment variable as required.
Testing strategy:
Started two builds:
- With the environment variable set, the RDP server starts, and I was able to connect to it.
- Without the environment variable set, the RDP server wasn't started.
Known issues with pull request:
This requires developers to remember to remove the environment variable when they are done.
Change log entries:
None
Code Review Checklist:
- [x] Pull Request description:
- description is up to date
- change log entries
- [x] Testing:
- Unit tests
- System (end to end) tests
- Manual testing
- [x] API is compatible with existing add-ons.
- [x] Documentation:
- User Documentation
- Developer / Technical Documentation
- Context sensitive help for GUI changes
- [x] UX of all users considered:
- Speech
- Braille
- Low Vision
- Different web browsers
- Localization in other languages / culture than English
- PASS: Translation comments check.
- PASS: Unit tests.
- PASS: Lint check.
- FAIL: System tests. See test results for more information.
- Build (for testing PR): https://ci.appveyor.com/api/buildjobs/oajhv2f45tjycp8r/artifacts/output/nvda_snapshot_pr14004-26141,e869277f.exe
See test results for failed build of commit e869277f3b
- PASS: Translation comments check.
- PASS: Unit tests.
- PASS: Lint check.
- FAIL: System tests. See test results for more information.
- Build (for testing PR): https://ci.appveyor.com/api/buildjobs/lv4h290j0fqosuri/artifacts/output/nvda_snapshot_pr14004-26142,e869277f.exe
See test results for failed build of commit e869277f3b
To prevent the focus error (caused by Docker Desktop asking for feedback):
- Connect via RDP during the build
- Close the feedback window
- Set focus to (click on) the Appveyor window (this needs focus so that it can create new processes with focus).
There are also other intermittent issues affecting the build, I'll resolve these in a separate PR.
- PASS: Translation comments check.
- PASS: Unit tests.
- PASS: Lint check.
- FAIL: System tests. See test results for more information.
- Build (for testing PR): https://ci.appveyor.com/api/buildjobs/7thexqeqjswmjy2t/artifacts/output/nvda_snapshot_pr14004-26145,f448d0cf.exe
See test results for failed build of commit f448d0cf53
Has this been reported to Appveyor? I assume this can affect more system tests of other projects.
- PASS: Translation comments check.
- PASS: Unit tests.
- PASS: Lint check.
- FAIL: System tests. See test results for more information.
- Build (for testing PR): https://ci.appveyor.com/api/buildjobs/ctmt8j8qhytqiaa1/artifacts/output/nvda_snapshot_pr14004-26157,a46ecbe0.exe
See test results for failed build of commit a46ecbe034
- PASS: Translation comments check.
- PASS: Unit tests.
- PASS: Lint check.
- FAIL: System tests. See test results for more information.
- Build (for testing PR): https://ci.appveyor.com/api/buildjobs/qcqxnjvcal7xsi2h/artifacts/output/nvda_snapshot_pr14004-26164,a46ecbe0.exe
See test results for failed build of commit a46ecbe034