nvda icon indicating copy to clipboard operation
nvda copied to clipboard

Table sayAll commands

Open mltony opened this issue 2 years ago • 9 comments

Is your feature request related to a problem? Please describe.

  1. I would like to have sayAll to read table column/row.
  2. I would like to have a way to read the first cell in current column/row without moving the cursor.

Describe the solution you'd like

I propose to implement 4 table-related keystrokes:

  • NVDA+Control+Alt+RightArrow/DownArrow: reads cells in current row/column starting from the current cell. Will stop reading once reaches the end of table. Will move caret as it reads every next cell.
  • NVDA+Control+Alt+LeftArrow/UpArrow: reads cells in current row/column starting from beginning. Will stop reading once reaches the end of table. Will NOT move caret, so this can be used to learn heading of current column/row. These commands are already implemented in Tony's enhancements add-on (although with different default key bindings) - as a proof of concept.

Describe alternatives you've considered

I am only aware of SayAll command (NVDA+DownArrow) that is similar to my proposed NVDA+Control+Alt+RightArrow command to read current row starting from current cell. However the default SayAll will not stop at the end of the row, so it is less convenient. I am not aware of sayAll for current column, nor any good solution of figuring out heading of current cell/current row in stock NVDA.

Additional context

Will be happy to implement this PR myself if no objections.

mltony avatar Mar 13 '22 00:03 mltony

cc: @seanbudd, @lukaszgo1, @CyrilleB79, @Adriani90.

mltony avatar Mar 13 '22 00:03 mltony

A +1 for this feature. I think these would be very useful commands to have for any of us who do a lot of work with tables on the web. I would love to see this feature in core.

XLTechie avatar Mar 13 '22 00:03 XLTechie

Hi @mltony Yes, it's useful, users in the Chinese community often ask about this feature, I've been looking for it for a long time and luckily found it in Tony's Enhancement add-on. Would love to see it in the NVDA core. Thanks

cary-rowen avatar Mar 13 '22 02:03 cary-rowen

If it is described as a "say all" command, the caret should move (e.g. cell by cell) while the cells are read. Is this what you want from this feature? E.g. when you press NVDA+ctrl+alt+downArrow and if you do not press ctrl before, the caret ends up in the last cell of the table? If you prefer to have all the cells read as an information but keep the caret in the current cell, the command should not use the "say all" terminology; it should rather be called "read column end" or something equivalent.

Also related even if not duplicate: #1911, #901

CyrilleB79 avatar Mar 13 '22 14:03 CyrilleB79

Hi @seanbudd @CyrilleB79 The discussion and proof in #1911 is enough to make this feature even more necessary, What's NVAccess worrying about right now, someone desperately needed this feature a decade ago, and what's the reason we haven't brought it into NVDA core yet? Feature requests related to this seem to have not stopped for a decade. Really looking forward to seeing this feature implemented. Thanks

cary-rowen avatar Mar 15 '22 03:03 cary-rowen

With the "triaged" label applied, we agree that this concept would be useful, and would accept a pull request for this feature into NVDA core. Before preparing a pull request, consider writing up a basic design proposal first, so that time isn't wasted implementing the PR in an unacceptable way.

seanbudd avatar Mar 15 '22 03:03 seanbudd

Hi, Thanks to @seanbudd for clarifying this, cc @mltony

Grateful

cary-rowen avatar Mar 15 '22 05:03 cary-rowen

Thanks @mltony for great work.

cary-rowen avatar Jul 13 '22 05:07 cary-rowen

Reintroduced via 9d25bac

seanbudd avatar Jul 27 '22 06:07 seanbudd

Issue: the NVDA+control+alt+arrow combinations conflict with the synth setting ring commands in NVDA's laptop layout.

tmthywynn8 avatar Oct 11 '22 04:10 tmthywynn8

@tmthywynn8 please raise a new issue so we can ensure this is fixed in 2022.4

seanbudd avatar Oct 11 '22 05:10 seanbudd

Issue: the NVDA+control+alt+arrow combinations conflict with the synth setting ring commands in NVDA's laptop layout.

In laptop layout, synth settings ring uses NVDA+control+arrow without alt.

CyrilleB79 avatar Oct 11 '22 09:10 CyrilleB79

In laptop layout, synth settings ring uses NVDA+control+arrow without alt.

You are absolutely correct. I apologize for the human error.

tmthywynn8 avatar Oct 11 '22 20:10 tmthywynn8