addon-datastore icon indicating copy to clipboard operation
addon-datastore copied to clipboard

Superfluous comment when verifySubmitterjob fails

Open nvdaes opened this issue 1 year ago • 0 comments

Summary

The createManualApproval job is triggered when verifySubmitter job fails, and this maybe hard to avoid. This is harmless and doesn'thave negative effects, since the pull request to approve add-ons won't be created, because the reviewedAddons.json file is not modified by previous jobs. However, the superfluous comment may be confusing. See

#3086, specifically:

https://github.com/nvaccess/addon-datastore/issues/3806#issuecomment-2170946606

Proposal

Create a PR in nvaccess/addon-datastore-staging, trying to post the comment just if the cpr step has a number corresponding to a created pull request.

nvdaes avatar Jun 16 '24 08:06 nvdaes