XCube icon indicating copy to clipboard operation
XCube copied to clipboard

fvdb pip install build fails

Open d32sharm opened this issue 1 year ago • 1 comments

At the FVDB install step, I am facing an issue where the build fails. It appears that system runs out of memory. I have 32 GB ram in the system. I tried by passing these arguments to avoid caching during build --no-cache-dir --no-build-isolation. Also tried to limit the number of threads during build.

However still facing the same issue. Could you kindly assist with this?

d32sharm avatar Sep 12 '24 20:09 d32sharm

If anyone is also trying to do something like this, I found a workaround. It's hacky AF, but it works. https://github.com/ValyrianTech/ComfyUI_with_Flux/blob/main/comfyui-with-flux/replaceDefaultGraph.py

WouterGlorieux avatar Sep 01 '24 20:09 WouterGlorieux

If anyone is also trying to do something like this, I found a workaround. It's hacky AF, but it works. https://github.com/ValyrianTech/ComfyUI_with_Flux/blob/main/comfyui-with-flux/replaceDefaultGraph.py

You probably don't want to do that as the build hash changes for every frontend release

huchenlei avatar Sep 01 '24 22:09 huchenlei

If you need to overwrite the default graph you can use ComfyUI-Custom-Scripts. Or you want to implement yourself you can reference the source code here: https://github.com/pythongosssss/ComfyUI-Custom-Scripts/blob/da87f6112daa8f37b293b12fc7ab260ff835e301/web/js/workflows.js#L294

huchenlei avatar Sep 01 '24 22:09 huchenlei

Yeah, looking at the name of the asset file I also suspected it would be a temporary fix, I guess next time I'll just have to add some code to figure out the new file. I'm already using ComfyUI-Custom-Scripts, but that still requires someone to click the load default button, on the very first startup it still used the defaultGraph.

WouterGlorieux avatar Sep 01 '24 23:09 WouterGlorieux

Yeah, looking at the name of the asset file I also suspected it would be a temporary fix, I guess next time I'll just have to add some code to figure out the new file. I'm already using ComfyUI-Custom-Scripts, but that still requires someone to click the load default button, on the very first startup it still used the defaultGraph.

If your need is to hijack the initial load, I would recommend you look at https://github.com/Comfy-Org/ComfyUI_frontend/blob/8ba5da14bc65d1c4d88bd17ffc6836cc1a3c15ed/src/scripts/app.ts#L1881-L1901

By setting Comfy.PreviousWorkflow in LocalStorage, you can change the initial load workflow. You just need to inject your script in index.html to modify localstorage, before the whole app's setup function.

huchenlei avatar Sep 02 '24 00:09 huchenlei

I will try support modify default workflow in a less hacky way later, but for now you can try approach this task with localStorage overwrite.

huchenlei avatar Sep 02 '24 00:09 huchenlei

imagehttps://github.com/pythongosssss/ComfyUI-Custom-Scripts

toyxyz avatar Sep 03 '24 02:09 toyxyz

I'm not the original poster, but I do use their one-click installer for cloud services. While modifying localStorage by injecting an early-loaded script into the html is certainly one approach, wouldn't it be nice for all Comfy users to be able to just swap out one JSON file for another?

A hard-coded default workflow seems awfully prone to becoming outdated the moment it's deployed, given how quickly things are moving in this space. I realize that I could be spending this time opening a PR and maybe I will when I find the time, but in the meantime please take this as a suggestion for improvement from someone who appreciates this tool and all the work that has gone into it.

greeze avatar Feb 05 '25 18:02 greeze