GSCNN icon indicating copy to clipboard operation
GSCNN copied to clipboard

Published 20 hours ago • verified publisher icon nv-tlabs

Questions about the numerical_gradients_2d function

Open lijing1996 opened this issue 5 years ago • 2 comments

Thanks for sharing your work! It seems a bug here:

https://github.com/nv-tlabs/GSCNN/blob/64f84878c6d4aabbf74d7e74fe27f38aa408c7ec/my_functionals/custom_functional.py#L38-L52 The numerical_gradients_2d function call this function that return the input directly and the input is only processed by the triangle filter. I wonder whether it was a bug here.

lijing1996 avatar Sep 15 '19 12:09 lijing1996

Hi, thanks for your interest in our work!

I believe this is a bug, probably an old debugging artifact that got reinstantiated when we were cleaning our code for release. I'll investigate into this a bit more later when I have a bit more time on my hands. Sorry for the inconvenience. :/

tovacinni avatar Sep 18 '19 23:09 tovacinni

Hi, thanks for your interest in our work!

I believe this is a bug, probably an old debugging artifact that got reinstantiated when we were cleaning our code for release. I'll investigate into this a bit more later when I have a bit more time on my hands. Sorry for the inconvenience. :/

thank you! I look forward to your training code!

shoutOutYangJie avatar Sep 20 '19 10:09 shoutOutYangJie