feat(preview): add some accessability props to homepage elements

Open btkostner opened this issue 4 years ago • 2 comments

This adds some accessibility warnings caught from lighthouse.

I think the docus AppAside organism could use a little love too but I'm not going to talk through the whole thing here.

Jul 10 '21 21:07 btkostner

Hey @btkostner ; thank you a lot for the PR 😄

Would love to get your insights about AppAside!

@bdrtsky ; could you take a look at this PR?

Jul 10 '21 22:07 Tahul

@Tahul Because it's a slide out navigation, I'd include on the menu buttons (and the back button):

aria-label="open navigation" aria-controls="id of the aside" :aria-expanded="$menu.visible"

I'd also add something like esc keybind to close the navigation menu, and set focus to the first nav item when the menu is open (otherwise tab goes between page elements and not the menu)

Jul 10 '21 23:07 btkostner