ui icon indicating copy to clipboard operation
ui copied to clipboard

Published 20 hours ago • verified publisher icon nuxt

feat(Rating): new component

Open larrasu opened this issue 2 years ago • 10 comments
trafficstars

Resolves #505

  • Works with the Form component

Form validation looks a bit ugly since you cannot add borders or rings around the rating icons. drop-shadow class of Tailwind doesn't support other colors.

Any help is appreciated.

larrasu avatar Aug 08 '23 21:08 larrasu

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

bolt-new-by-stackblitz[bot] avatar Aug 08 '23 21:08 bolt-new-by-stackblitz[bot]

Live Preview ready!

Name Edit Preview Latest Commit
ui Edit on Studio ↗︎ View Live Preview 5ae6d55e7249f1d138832d0937e187f54b2944df

nuxt-studio[bot] avatar Aug 08 '23 21:08 nuxt-studio[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ui ❌ Failed (Inspect) Nov 30, 2023 7:21pm

vercel[bot] avatar Aug 08 '23 21:08 vercel[bot]

Fantastic work, @larrasu! The component is truly impressive. Best of luck

Haythamasalama avatar Aug 11 '23 21:08 Haythamasalama

@Haythamasalama, I've implemented your suggestions. This is my first code contribution to an open source here on GitHub so I'm a bit lost on what to do. Thank you for the suggestions and the kind words! Really appreciate it!

larrasu avatar Aug 28 '23 18:08 larrasu

@Haythamasalama, I've implemented your suggestions. This is my first code contribution to an open source here on GitHub so I'm a bit lost on what to do. Thank you for the suggestions and the kind words! Really appreciate it!

@larrasu, Great work! 🚀

Haythamasalama avatar Aug 28 '23 20:08 Haythamasalama

@larrasu Amazing work! My feedback would be to disable hover effects on read-only mode. Currently on hover the active elements become transparent and might lead to a confusion. Everything else looks amazing so, again, huge congrats for this PR! 😄 🚀

eduayme avatar Aug 30 '23 15:08 eduayme

I solved the conflicts and refactored it, but still need to review and check all functionality @larrasu?

Haythamasalama avatar Oct 05 '23 14:10 Haythamasalama

I solved the conflicts and refactored it, but still need to review and check all functionality @larrasu?

Hover styles are not working for some reason. Thank you for updating this by the way!

EDIT: All fixed now.

larrasu avatar Oct 05 '23 17:10 larrasu

I have made some updates to add the disabled prop and added a type for the size and update docs. Let me what you think.

Haythamasalama avatar Oct 05 '23 18:10 Haythamasalama