nuxt
nuxt copied to clipboard
nuxt
fix(utils): nuxt.config.js is not in cwd
Types of changes
- [x] Bug fix (a non-breaking change which fixes an issue)
Description
this resolves https://github.com/nuxt/nuxt.js/issues/9640
Checklist:
- [x] All new and existing tests are passing.
Codecov Report
Merging #9701 (f411374) into dev (b014777) will not change coverage. The diff coverage is
n/a.
@@ Coverage Diff @@
## dev #9701 +/- ##
=======================================
Coverage 65.17% 65.17%
=======================================
Files 94 94
Lines 4109 4109
Branches 1127 1127
=======================================
Hits 2678 2678
Misses 1152 1152
Partials 279 279
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 65.17% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| packages/cli/src/utils/generate.js | 0.00% <ø> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update b014777...f411374. Read the comment docs.
El El mar, ago. 24, 2021 a la(s) 4:12 a. m., pooya parsa < @.***> escribió:
@.**** commented on this pull request.
In In packages/cli/src/utils/generate.js https://github.com/nuxt/nuxt.js/pull/9701#discussion_r694668154::
@@ -169,7 +169,7 @@ export async function snapshot ({ globbyOptions, ignore, rootDir }) { const files = await globby('**/.', { ...globbyOptions, ignore,
- cwd: rootDir,
- cwd: path.normalize(rootDir),
One downside of upath, is that it seems not supporting windows network mounts (that might be currently used by nuxt2 users). If path.normalize solving issue with globby is less risky change (till we have unpath for better normalization)
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nuxt/nuxt.js/pull/9701#discussion_r694668154, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATOUUODH7EX2Q647F4YT4XLT6NPBFANCNFSM5CSSE6LA .
El El mar, ago. 24, 2021 a la(s) 4:19 a. m., Ranulfo Garcia El AltepeMerario @.***> escribió:
El El mar, ago. 24, 2021 a la(s) 4:12 a. m., pooya parsa < @.***> escribió:
@.**** commented on this pull request.
In packages/cli/src/utils/generate.js https://github.com/nuxt/nuxt.js/pull/9701#discussion_r694668154:
@@ -169,7 +169,7 @@ export async function snapshot ({ globbyOptions, ignore, rootDir }) { const files = await globby('**/.', { ...globbyOptions, ignore,
- cwd: rootDir,
- cwd: path.normalize(rootDir),
One downside of upath, is that it seems not supporting windows network mounts (that might be currently used by nuxt2 users). If path.normalize solving issue with globby is less risky change (till we have unpath for better normalization)
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nuxt/nuxt.js/pull/9701#discussion_r694668154, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATOUUODH7EX2Q647F4YT4XLT6NPBFANCNFSM5CSSE6LA .
@harishsg99 Would you confirm whether this change is still needed on the latest 2.16.2 (which has a newer version of globby than when you submitted this PR)?
