nuxt icon indicating copy to clipboard operation
nuxt copied to clipboard

refactor(nuxt): replace Nuxt payload's error type with NuxtError

Open DamianGlowala opened this issue 1 year ago โ€ข 3 comments

๐Ÿ”— Linked issue

โ“ Type of change

  • [ ] ๐Ÿ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • [ ] ๐Ÿž Bug fix (a non-breaking change that fixes an issue)
  • [x] ๐Ÿ‘Œ Enhancement (improving an existing functionality like performance)
  • [ ] โœจ New feature (a non-breaking change that adds functionality)
  • [ ] ๐Ÿงน Chore (updates to the build process or auxiliary tools and libraries)
  • [ ] โš ๏ธ Breaking change (fix or feature that would cause existing functionality to change)

๐Ÿ“š Description

Enforces a NuxtError type on the NuxtPayload's error property for consistency.

๐Ÿ“ Checklist

  • [ ] I have linked an issue or discussion.
  • [ ] I have added tests (if possible).
  • [x] I have updated the documentation accordingly.

DamianGlowala avatar Jan 23 '24 16:01 DamianGlowala

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

stackblitz[bot] avatar Jan 23 '24 16:01 stackblitz[bot]

Live Preview ready!

Name Edit Preview Latest Commit
Nuxt Docs Edit on Studio โ†—๏ธŽ View Live Preview a47ecb405e866ef0273d2d093a9a38bc6aa3fa7c

nuxt-studio[bot] avatar Jan 25 '24 16:01 nuxt-studio[bot]

Added! As the nuxt-error-page.vue isn't using TypeScript, we probably need to leave it as it is: https://github.com/nuxt/nuxt/blob/a995f724eadaa06d5443b188879ac18dfe73de2e/packages/nuxt/src/app/components/nuxt-error-page.vue#L9

DamianGlowala avatar Jan 25 '24 16:01 DamianGlowala