nuxt icon indicating copy to clipboard operation
nuxt copied to clipboard

fix(vite): inline styles for imports used only on server

Open danielroe opened this issue 1 year ago โ€ข 1 comments

๐Ÿ”— Linked issue

resolves https://github.com/nuxt/nuxt/issues/24480 resolves https://github.com/nuxt/nuxt/issues/25330

โ“ Type of change

  • [ ] ๐Ÿ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • [x] ๐Ÿž Bug fix (a non-breaking change that fixes an issue)
  • [ ] ๐Ÿ‘Œ Enhancement (improving an existing functionality like performance)
  • [ ] โœจ New feature (a non-breaking change that adds functionality)
  • [ ] ๐Ÿงน Chore (updates to the build process or auxiliary tools and libraries)
  • [ ] โš ๏ธ Breaking change (fix or feature that would cause existing functionality to change)

๐Ÿ“š Description

Not quite sure why, but we were previously not extracting styles for components that didn't have a counterpart in the client build. This change avoids the early return, but needs some extra testing to see what I was thinking in https://github.com/nuxt/nuxt/pull/21573 ๐Ÿค”

It also needs a simple test.

๐Ÿ“ Checklist

  • [x] I have linked an issue or discussion.
  • [ ] I have added tests (if possible).
  • [ ] I have updated the documentation accordingly.

danielroe avatar Jan 23 '24 15:01 danielroe

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.