nuxt icon indicating copy to clipboard operation
nuxt copied to clipboard

refactor(config,vue-app): change back to app namespace

Open danielroe opened this issue 2 years ago • 1 comments

Types of changes

  • [ ] Bug fix (a non-breaking change which fixes an issue)
  • [ ] New feature (a non-breaking change which adds functionality)
  • [x] Breaking change (fix or feature that would cause existing functionality to change)

Description

For parity with Nuxt 3, this changes the names (but not the behaviour) of app.assetsPath -> app.buildAssetsPath and publicRuntimeConfig._app -> publicRuntimeConfig.app.

Nuxt should merge the app config with any existing properties in publicRuntimeConfig.app to minimise the impact, but still this should be recognised as a breaking change.

Checklist:

  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly. (PR: #)
  • [ ] I have added tests to cover my changes (if not applicable, please state why)
  • [x] All new and existing tests are passing.

danielroe avatar Jan 10 '22 12:01 danielroe

Codecov Report

Merging #10197 (cdd8383) into dev (777a4b7) will increase coverage by 0.00%. The diff coverage is 80.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev   #10197   +/-   ##
=======================================
  Coverage   65.15%   65.15%           
=======================================
  Files          94       94           
  Lines        4155     4156    +1     
  Branches     1172     1172           
=======================================
+ Hits         2707     2708    +1     
  Misses       1169     1169           
  Partials      279      279           
Flag Coverage Δ
unittests 65.15% <80.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/vue-renderer/src/renderer.js 0.00% <0.00%> (ø)
packages/config/src/options.js 97.14% <100.00%> (+0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 777a4b7...cdd8383. Read the comment docs.

codecov-commenter avatar Jan 20 '22 10:01 codecov-commenter