modules icon indicating copy to clipboard operation
modules copied to clipboard

add more details to download count on full details view

Open BracketJohn opened this issue 2 years ago • 4 comments

When checking out the modules page today, I saw that the download count for nuxt-session is off. It is correct on the modules details page

On the repo: https://github.com/sidebase/nuxt-session image

On the modules page: https://nuxt.com/modules image

On the modules details page: https://nuxt.com/modules/session image

In addition the maintainer-count seems to be broken (5 on overview, 1 on details page of nuxt.com/modules).

So in summary:

  • [ ] download counts between modules-overview and module-details is off
  • [ ] maintainer counts between modules-overview and module-details is off

BracketJohn avatar Nov 24 '22 08:11 BracketJohn

We show the monthly download count, not downloads across all time.

image.png

The maintainer count is coming from the data in this repository - so you should feel free to update it.

https://github.com/nuxt/modules/blob/3d6be08bffe66714c2a8fec873c3b60e1eb072b8/lib/modules.ts#L101-L114

danielroe avatar Nov 24 '22 10:11 danielroe

I see, thanks - maybe it would be worth it to update the text to / month?

Other than that my question has been answered and if we don't want to adapt it to say / month the issue can be closed, thanks 🙌

BracketJohn avatar Nov 24 '22 11:11 BracketJohn

I think it might nice to be something like x installs this month in the 'fuller' detail page version, keeping the minimal approach on the card. wdyt?

danielroe avatar Nov 24 '22 12:11 danielroe

Yes, that would be great + maybe we can add a tooltip to the card-stats on hover, to also give that context there?

BracketJohn avatar Nov 24 '22 16:11 BracketJohn