add nuxt-vue3-google-signin (#429)
Closes #429
Looks good to me 😊
I believe the next step would be to have a nice integration to keep the user session but not required now for it to be merged.
Waiting also for a small review from @pi0
@Atinux is it advisable to use runtimeConfig instead of appConfig for this plugin? I had a discussion with @danielroe in DC about this. We were discussing about having both same time
I am wondering since this is only used at this module is purely on the vue part to not leverage the app.config directly?
So then maybe i'll stick into app.config as per docs mentioned already
export default defineNuxtConfig({
modules: [
'nuxt-vue3-google-signin'
],
googleSignIn: {
clientId: 'CLIENT ID OBTAINED FROM GOOGLE API CONSOLE',
}
})
Thanks for PR @kasvith. I will review impl shortly. Options of google-signin seems to be public but generally, I wouldn't advice using app.config at least today for storing authentication related setup. Different flows can potentially include some secrets to the client bundle (PS: This feature is only available in edge).
Hi @pi0 any comments on the PR?
Thanks @danielroe @Atinux @pi0