modules icon indicating copy to clipboard operation
modules copied to clipboard

add nuxt-vue3-google-signin (#429)

Open kasvith opened this issue 3 years ago • 5 comments

Closes #429

kasvith avatar Aug 17 '22 19:08 kasvith

Looks good to me 😊

I believe the next step would be to have a nice integration to keep the user session but not required now for it to be merged.

Waiting also for a small review from @pi0

atinux avatar Aug 22 '22 16:08 atinux

@Atinux is it advisable to use runtimeConfig instead of appConfig for this plugin? I had a discussion with @danielroe in DC about this. We were discussing about having both same time

kasvith avatar Aug 22 '22 18:08 kasvith

I am wondering since this is only used at this module is purely on the vue part to not leverage the app.config directly?

atinux avatar Aug 22 '22 21:08 atinux

So then maybe i'll stick into app.config as per docs mentioned already

export default defineNuxtConfig({
  modules: [
    'nuxt-vue3-google-signin'
  ],
  googleSignIn: {
    clientId: 'CLIENT ID OBTAINED FROM GOOGLE API CONSOLE',
  }
})

kasvith avatar Aug 22 '22 21:08 kasvith

Thanks for PR @kasvith. I will review impl shortly. Options of google-signin seems to be public but generally, I wouldn't advice using app.config at least today for storing authentication related setup. Different flows can potentially include some secrets to the client bundle (PS: This feature is only available in edge).

pi0 avatar Aug 23 '22 08:08 pi0

Hi @pi0 any comments on the PR?

kasvith avatar Jan 10 '23 20:01 kasvith

Thanks @danielroe @Atinux @pi0

kasvith avatar Jan 12 '23 05:01 kasvith