image icon indicating copy to clipboard operation
image copied to clipboard

feat(provider): add directus (v0)

Open shadow81627 opened this issue 3 years ago • 3 comments

#368

shadow81627 avatar Jul 16 '22 02:07 shadow81627

Codecov Report

Merging #572 (231900b) into v0 (d837956) will increase coverage by 0.37%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##               v0     #572      +/-   ##
==========================================
+ Coverage   58.73%   59.11%   +0.37%     
==========================================
  Files          34       35       +1     
  Lines         647      653       +6     
  Branches      218      220       +2     
==========================================
+ Hits          380      386       +6     
  Misses        266      266              
  Partials        1        1              
Impacted Files Coverage Δ
src/provider.ts 74.28% <ø> (ø)
src/runtime/providers/directus.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d837956...231900b. Read the comment docs.

codecov-commenter avatar Jul 16 '22 02:07 codecov-commenter

@shadow81627 Thanks & awesome! let's hope this gets reviewed and merged soon ^^

vanling avatar Jul 17 '22 14:07 vanling

@pi0

melrefaie avatar Aug 03 '22 18:08 melrefaie

Not sure if this PR just needs to be updated with upstream changes, but in my testing, in order to get transforms to work, I need to JSON.stringify(...) the data, like so:

<template>
      <nuxt-img :src="imageId" width="260" :modifiers="{ transforms: JSON.stringify(imageTransforms) }" />
</template>
const imageTransforms = [['blur', 45]]

That should probably happen inside of the provider?

genu avatar Oct 24 '22 18:10 genu