framework icon indicating copy to clipboard operation
framework copied to clipboard

feat: initial vite 4 implementation for testing

Open danielroe opened this issue 2 years ago • 1 comments

🔗 Linked issue

❓ Type of change

  • [ ] 📖 Documentation (updates to the documentation or readme)
  • [ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
  • [x] 👌 Enhancement (improving an existing functionality like performance)
  • [ ] ✨ New feature (a non-breaking change that adds functionality)
  • [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR enables us to track issues with the upcoming vite 4 release ahead of time. Current known issues with vite 4 or rollup 3 are:

  • [ ] breakage when emitting inlined SSR styles giving an error like Could not resolve "./error-500-styles-1.mjs-!~{004}~.js" from ".nuxt/dist/server/_nuxt/error-500-styles.8cad04bf.mjs"

📝 Checklist

  • [ ] I have linked an issue or discussion.
  • [ ] I have updated the documentation accordingly.

danielroe avatar Nov 21 '22 17:11 danielroe

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

codesandbox[bot] avatar Nov 21 '22 17:11 codesandbox[bot]

@danielroe Do you mind to rebase and also bump nitropack to 2.x edge to move it forward and try on edge channel?

pi0 avatar Dec 12 '22 13:12 pi0

@pi0 Type check now failing due to upstream nitro typing issue: https://github.com/unjs/nitro/pull/751

danielroe avatar Dec 12 '22 14:12 danielroe

Merging to test on edge. We'll revert back to non-edge nitropack before release.

danielroe avatar Dec 12 '22 15:12 danielroe