fonts icon indicating copy to clipboard operation
fonts copied to clipboard

feat: support variable axis

Open qwerzl opened this issue 1 year ago • 3 comments
trafficstars

This PR adds support for variable font axis. It's quite sad that AFAIK only Google provides this level of configuration.

qwerzl avatar Apr 26 '24 14:04 qwerzl

Codecov Report

Attention: Patch coverage is 82.50000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 45.91%. Comparing base (d83aa0d) to head (98d3697).

Files Patch % Lines
playground/pages/providers/google.vue 0.00% 11 Missing :warning:
src/module.ts 50.00% 3 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
+ Coverage   45.25%   45.91%   +0.65%     
==========================================
  Files          56       56              
  Lines        3964     4036      +72     
  Branches      429      450      +21     
==========================================
+ Hits         1794     1853      +59     
- Misses       2130     2145      +15     
+ Partials       40       38       -2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 27 '24 23:04 codecov-commenter

Hi @danielroe, the type issues are fixed and I've added tests for Recursive. Sorry I didn't see the failed checks yesterday so it took some time.

qwerzl avatar Apr 28 '24 01:04 qwerzl

@danielroe I've also thought about this, but I'm not sure whether font-variation-settings allows a range of values.

qwerzl avatar May 03 '24 09:05 qwerzl

Now that unifont is released, I think this PR should be closed.

For fine-grained variable axis control of providers other than google, I'm thinking about a variable axis subsetter built into unifont once klippa supports it.

qwerzl avatar Oct 05 '24 05:10 qwerzl

we could also open again on unifont - for nuxt/fonts i wanted to think if there was a way to make this zero config but i know it’s taken too long 🙈

danielroe avatar Oct 05 '24 11:10 danielroe