turnstile icon indicating copy to clipboard operation
turnstile copied to clipboard

chore(component): remove `nextTick`

Open dargmuesli opened this issue 1 year ago • 3 comments

Both mentioned issues are resolved now.

dargmuesli avatar Jan 24 '24 01:01 dargmuesli

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c564106) 19.26% compared to head (8aa2a4d) 19.34%.

Files Patch % Lines
src/runtime/components/NuxtTurnstile.vue 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #295      +/-   ##
==========================================
+ Coverage   19.26%   19.34%   +0.07%     
==========================================
  Files          12       12              
  Lines         493      491       -2     
  Branches       23       23              
==========================================
  Hits           95       95              
+ Misses        398      396       -2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 24 '24 01:01 codecov[bot]

Nice! Have you confirmed that client-side navigation to a page with the Turnstile component still works?

danielroe avatar Jan 24 '24 09:01 danielroe

Yes, to the best of my knowledge: I enabled the playground widgets to load right away, navigated to /home and back and I noticed no issues.

dargmuesli avatar Jan 25 '24 01:01 dargmuesli

I think this is no longer relevant with Nuxt Scripts implementation

danielroe avatar Jul 19 '24 06:07 danielroe

Right, I think so too :rocket:

dargmuesli avatar Jul 19 '24 14:07 dargmuesli