ionic icon indicating copy to clipboard operation
ionic copied to clipboard

feat: add IonAnimation component

Open Lexpeartha opened this issue 1 year ago • 8 comments

Resolves #34

I'm looking for a feedback, mostly regarding component's API

This PR is still WIP

Lexpeartha avatar Aug 21 '22 16:08 Lexpeartha

Someone is attempting to deploy a commit to a Personal Account owned by @danielroe on Vercel.

@danielroe first needs to authorize it.

vercel[bot] avatar Aug 21 '22 16:08 vercel[bot]

Codecov Report

Merging #40 (d051cf2) into main (8917577) will increase coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
+ Coverage   92.18%   92.22%   +0.03%     
==========================================
  Files           7        8       +1     
  Lines         448      463      +15     
  Branches       37       38       +1     
==========================================
+ Hits          413      427      +14     
- Misses         35       36       +1     
Impacted Files Coverage Δ
src/module.ts 96.55% <100.00%> (-0.31%) :arrow_down:
src/parts/components.ts 100.00% <100.00%> (ø)
src/parts/router.ts 92.75% <100.00%> (+0.10%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Aug 21 '22 16:08 codecov-commenter

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nuxt-ionic ✅ Ready (Inspect) Visit Preview Aug 25, 2022 at 8:46AM (UTC)

vercel[bot] avatar Aug 21 '22 16:08 vercel[bot]

Worth noting than in future with more components it would make more sense to use addComponentsDir for auto-importing multiple utility components

Lexpeartha avatar Aug 21 '22 19:08 Lexpeartha

Also what do you say I create 4th tab in playground showcasing all animations from the ionic docs with this component? Would that be over-kill?

Lexpeartha avatar Aug 21 '22 19:08 Lexpeartha

4th tab sounds great!

danielroe avatar Aug 23 '22 12:08 danielroe

I think core component is ready. Only thing left is maybe more animation examples, and updating the docs

Lexpeartha avatar Aug 24 '22 22:08 Lexpeartha

Only thing I'm not really sure how to approach is grouped animation. It allows for using one root animation, to play children animations in parallel. However to do this, I think I need a better way than scoped slot to expose animation object to page/component it is being using in. Any ideas?

Lexpeartha avatar Aug 25 '22 15:08 Lexpeartha

@danielroe Could you take a look at docs? Is this enough of documentation for such a component with lots of props, or should I be more thorough?

Lexpeartha avatar Aug 26 '22 14:08 Lexpeartha

Only thing I'm not really sure how to approach is grouped animation. It allows for using one root animation, to play children animations in parallel. However to do this, I think I need a better way than scoped slot to expose animation object to page/component it is being using in. Any ideas?

Also about exposing an animation object, I tried to do some provide/inject trickery to automatically group animations if they are direct children of the another animation component, but to no avail. Only thing that comes to my mind now is to expose it via emit, but that approach seems very intuitive to me

Lexpeartha avatar Aug 26 '22 14:08 Lexpeartha

I'm merging the PR. If you think docs need more work lmk, but I think component is straight-forward enough that this will do

Lexpeartha avatar Aug 30 '22 06:08 Lexpeartha