i18n
i18n copied to clipboard
feat: multiple locales on multiple domains
๐ Linked issue
#1161
โ Type of change
- [ ] ๐ Documentation (updates to the documentation, readme or JSdoc annotations)
- [ ] ๐ Bug fix (a non-breaking change that fixes an issue)
- [ ] ๐ Enhancement (improving an existing functionality like performance)
- [X] โจ New feature (a non-breaking change that adds functionality)
- [ ] ๐งน Chore (updates to the build process or auxiliary tools and libraries)
- [ ] โ ๏ธ Breaking change (fix or feature that would cause existing functionality to change)
๐ Description
Resolves #1161 by allowing the same locale on multiple domains. Eg:
NL domain:
https://mydomain.nl/ -> https://mydomain.nl/ (nl language)
https://mydomain.nl/en -> https://mydomain.nl/en (en language)
https://mydomain.nl/de -> https://mydomain.nl/de (de language)
https://mydomain.nl/nl -> https://mydomain.nl/nl (404)
DE domain:
https://mydomain.de/ -> https://mydomain.nl/ (nl language)
https://mydomain.de/en -> https://mydomain.nl/en (en language)
https://mydomain.de/nl -> https://mydomain.nl/de (de language)
https://mydomain.de/de -> https://mydomain.de/de (404)
๐ Checklist
- [X] I have linked an issue or discussion.
- [x] I have added tests (if possible).
- [x] I have updated the documentation accordingly.
I've fixed the tests, all tests should pass now. Documentation has been added as well.
This would be a great functionality! I noticed there's no requested reviews, maybe you could resolve the conflicts and request someone to review this? ๐
This pull request has been deprecated, please see #3065