i18n icon indicating copy to clipboard operation
i18n copied to clipboard

Use `getFeatureFlags` also in vite config

Open qnp opened this issue 1 year ago • 1 comments

While roaming across the code-base, I wondered why there is no use of the getFeatureFlags in Vite config, but only in webpack one. Should not it be also used in Vite config, something like adding

config.define = assign(
  config.define,
  getFeatureFlags({
    jit: nuxtOptions.compilation.jit,
    compositionOnly: nuxtOptions.bundle.compositionOnly,
    fullInstall: nuxtOptions.bundle.fullInstall,
    dropMessageCompiler: nuxtOptions.compilation.jit ? nuxtOptions.bundle.dropMessageCompiler : false
  })
)

Best regards

qnp avatar Sep 06 '23 17:09 qnp

Thank you for your interest!

vits is unplugin-vue-i18n is used. unplugion-vue-i18n does not edit the feature flags directly, so sets them with option If you have ideas for refactoring, we would welcome PR :)

kazupon avatar Sep 07 '23 02:09 kazupon