google-fonts icon indicating copy to clipboard operation
google-fonts copied to clipboard

fix: update to latest `@nuxt/module-builder`

Open danielroe opened this issue 1 year ago โ€ข 2 comments

๐Ÿ”— Linked issue

โ“ Type of change

  • [ ] ๐Ÿ“– Documentation (updates to the documentation or readme)
  • [x] ๐Ÿž Bug fix (a non-breaking change that fixes an issue)
  • [ ] ๐Ÿ‘Œ Enhancement (improving an existing functionality)
  • [ ] โœจ New feature (a non-breaking change that adds functionality)
  • [ ] ๐Ÿงน Chore (updates to the build process or auxiliary tools and libraries)
  • [ ] โš ๏ธ Breaking change (fix or feature that would cause existing functionality to change)

๐Ÿ“š Description

Previous versions of @nuxt/module-builder produced incorrect types for files in the runtime/ directory. Specifically, a .d.ts declaration paired with a .mjs file. This isn't correct - it should be either .d.mts and .mjs or .d.ts and .js.

For maximum compatibility, @nuxt/module-builder v0.8 switched to .js extension for files in runtime/ directory.

With the latest Nuxt, this is now an error that removes correct plugin injection types.

Related PRs: https://github.com/nuxt/nuxt/pull/28480, https://github.com/nuxt/nuxt/pull/28593 See also https://github.com/nuxt/nuxt/issues/28672.

danielroe avatar Aug 25 '24 21:08 danielroe

Deploy Preview for pedantic-sinoussi-65c819 canceled.

Name Link
Latest commit f5d0cbd0ded12fc825dcf4ddfb7c7d908685b268
Latest deploy log https://app.netlify.com/sites/pedantic-sinoussi-65c819/deploys/66cba4dd43f9a3000873d999

netlify[bot] avatar Aug 25 '24 21:08 netlify[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.21%. Comparing base (7099819) to head (f5d0cbd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #209   +/-   ##
=======================================
  Coverage   67.21%   67.21%           
=======================================
  Files           7        7           
  Lines         305      305           
  Branches       27       27           
=======================================
  Hits          205      205           
  Misses         92       92           
  Partials        8        8           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 25 '24 21:08 codecov[bot]

Deploy Preview for pedantic-sinoussi-65c819 failed. Why did it fail? โ†’

Name Link
Latest commit 6b9ce5f765d7bd311b884c3ee81f813c4d70f36a
Latest deploy log https://app.netlify.com/sites/pedantic-sinoussi-65c819/deploys/67dc08add64ada0008bad74f

netlify[bot] avatar Mar 20 '25 12:03 netlify[bot]