color-mode icon indicating copy to clipboard operation
color-mode copied to clipboard

feat: add theme color support

Open Arecsu opened this issue 2 years ago • 3 comments
trafficstars

Original PR: https://github.com/nuxt-modules/color-mode/pull/121

Resolved all conflicts, some code refactoring and fixed a bug generated by the minify process, which made the feature unusable in production.

Debugging it was somewhat hard, because the dev playground doesn't use the production minified version of script.ts. It uses a symbolic link to it. Thus, using the production build in my personal blog resulted in a different interpretation of the JSON lodash literal compared to the one in the dev environment. Managed to solve it by forcing esbuild to keep the backticks.

Other changes: Added a // @ts-nocheck at the top of script.ts to get rid of a lot of type error lines in the code. Not a good solution given it should be a real Typescript file. Nonetheless, proper minifying the file while running the playground is out of the scope of this feature.

For now, it seems the feature works just fine. Tested in SSR: true and SSR: false. 🤗

Arecsu avatar Aug 18 '23 18:08 Arecsu

Live Preview ready!

Name Edit Preview Latest Commit
Color Mode Edit on Studio ↗︎ View Live Preview cdf55ecf3e629750f348616c3b46709f716999b9

nuxt-studio[bot] avatar Aug 18 '23 18:08 nuxt-studio[bot]

Deploy Preview for nuxt-color-mode failed.

Name Link
Latest commit cdf55ecf3e629750f348616c3b46709f716999b9
Latest deploy log https://app.netlify.com/sites/nuxt-color-mode/deploys/64dfbf9ce14a820008246695

netlify[bot] avatar Aug 18 '23 18:08 netlify[bot]