sentry-module icon indicating copy to clipboard operation
sentry-module copied to clipboard

Upgrade to Sentry packages v7

Open bmulholland opened this issue 3 years ago • 9 comments

https://github.com/getsentry/sentry-javascript/releases/tag/7.0.0

bmulholland avatar Jul 12 '22 14:07 bmulholland

Sentry blogged about the size reduction in v7, it would be great to have this updated so we can improve the perf of our Nuxt apps.

https://blog.sentry.io/2022/07/19/javascript-sdk-package-reduced/

@rchl is there a possibility of having Sentry as a peer dependancy so this module doesn't need to be re-published every time they make a release?

alexcroox avatar Jul 21 '22 18:07 alexcroox

@rchl is there a possibility of having Sentry as a peer dependancy so this module doesn't need to be re-published every time they make a release?

npm (and yarn too, pretty sure) will update the @sentry/* depenencies within specified range when running npm update @nuxtjs/sentry so there is not really a need to make those into peer dependencies.

rchl avatar Jul 21 '22 18:07 rchl

The range specifies 6, so upgrading to 7 is not possible right now.

bmulholland avatar Jul 21 '22 18:07 bmulholland

My answer was not in relation to updating to version 7 but only about upgrading to new patch/minor releases within the v6 range.

As far as upgrading to v7, this is a task on its own as it needs changes in the module and using peer dependencies wouldn't change anything in that regard.

rchl avatar Jul 21 '22 18:07 rchl

good to know about running npm update for minor bumps, thanks

alexcroox avatar Jul 21 '22 18:07 alexcroox

any ETA on this? @sentry/tracing it's blocked to V6 because @nuxtjs/sentry still used V6 and not 7.

LegendSebastiano-L avatar Sep 13 '22 06:09 LegendSebastiano-L

Hi, our company is going to use sentry-module in production but it doesn't support v7 libs. sentry.io ui warns that our code uses old sdk. Could you share some estimates or insights about the migration? Should we expect on the soon migration? Thanks a lot for your work!

glebv avatar Sep 29 '22 12:09 glebv

Not making any promises due to being short on time.

Technically there should be no issues with using v6. We are doing that at my company and as long as it works fine it's not a priority to update.

rchl avatar Sep 30 '22 08:09 rchl

@rchl thanks for your answer. Got it.

glebv avatar Sep 30 '22 08:09 glebv

I'm currently optimizing my nuxt app for google page speed tests and sentry code is quite a large piece of code. Upgrading to version 7 would be really helpful. Otherwise looks like I need to copy paste plugins and use sentry package directly.

vedmant avatar Oct 16 '22 22:10 vedmant

@rchl Do you have time to post a short description of what would be needed to make the upgrade happen? That way, maybe someone for whom it's a higher priority could make an attempt.

bmulholland avatar Oct 17 '22 10:10 bmulholland

The task would be to adapt the module so that it's compatible with the new SDK, paying attention to all breaking changes. Not much else to it, I think.

https://github.com/nuxt-community/sentry-module/issues/417 has some hints and even code to get this started.

rchl avatar Oct 17 '22 13:10 rchl

@vedmant maybe doing that work would be less work overall than the plugin copying you are considering?

bmulholland avatar Oct 17 '22 13:10 bmulholland